K8SPSMDB-976: Fix PBM config if there's no storage configured in CR (#1320)

* K8SPSMDB-976: Fix PBM config if there's no storage configured in CR

* fix pbm storage if credentials don't exist

---------

Co-authored-by: Viacheslav Sarzhan <[email protected]>

Author: egegunes

pkg/controller/perconaservermongodb/backup.go

@@ -14,6 +14,7 @@ import (
 	batchv1 "k8s.io/api/batch/v1"
 	corev1 "k8s.io/api/core/v1"
 	k8sErrors "k8s.io/apimachinery/pkg/api/errors"
+	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/util/retry"
@@ -368,17 +369,39 @@ func (r *ReconcilePerconaServerMongoDB) updatePITR(ctx context.Context, cr *api.
 			return errors.Wrap(err, "get pitr.enabled")
 		}
 
-		// if PiTR is enabled we know there is only one storage
-		var storage api.BackupStorageSpec
-		for name, stg := range cr.Spec.Backup.Storages {
-			storage = stg
-			log.Info("Configuring PBM with storage", "storage", name)
-			break
-		}
+		if len(cr.Spec.Backup.Storages) == 1 {
+			// if PiTR is enabled user can configure only one storage
+			var storage api.BackupStorageSpec
+			for name, stg := range cr.Spec.Backup.Storages {
+				storage = stg
+				log.Info("Configuring PBM with storage", "storage", name)
+				break
+			}
 
-		err = pbm.SetConfig(ctx, r.client, cr, storage)
-		if err != nil {
-			return errors.Wrap(err, "set PBM config")
+			var secretName string
+			switch storage.Type {
+			case api.BackupStorageS3:
+				secretName = storage.S3.CredentialsSecret
+			case api.BackupStorageAzure:
+				secretName = storage.Azure.CredentialsSecret
+			}
+
+			exists, err := secretExists(ctx, r.client, types.NamespacedName{Name: secretName, Namespace: cr.Namespace})
+			if err != nil {
+				return errors.Wrap(err, "check storage credentials secret")
+			}
+
+			if !exists {
+				log.Error(nil, "Storage credentials secret does not exist", "secret", secretName)
+				return nil
+			}
+
+			err = pbm.SetConfig(ctx, r.client, cr, storage)
+			if err != nil {
+				return errors.Wrap(err, "set PBM config")
+			}
+
+			log.Info("Configured PBM storage")
 		}
 
 		return nil
@@ -567,3 +590,16 @@ func (r *ReconcilePerconaServerMongoDB) resyncPBMIfNeeded(ctx context.Context, c
 
 	return nil
 }
+
+func secretExists(ctx context.Context, cl client.Client, nn types.NamespacedName) (bool, error) {
+	var secret corev1.Secret
+	err := cl.Get(ctx, nn, &secret)
+	if err != nil {
+		if k8serrors.IsNotFound(err) {
+			return false, nil
+		}
+		return false, err
+	}
+
+	return true, nil
+}