Skip to content

Commit 2b38a1f

Browse files
authored
Merge pull request #1346 from percona/CLOUD-789-2
2 parents 7c4fb6a + bb56f17 commit 2b38a1f

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

e2e-tests/functions

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1278,6 +1278,10 @@ function generate_vs_json() {
12781278
}
12791279

12801280
check_passwords_leak() {
1281+
local secrets
1282+
local passwords
1283+
local pods
1284+
12811285
secrets=$(kubectl_bin get secrets -o json | jq -r '.items[].data | to_entries | .[] | select(.key | (contains("_PASSWORD"))) | .value')
12821286
echo secrets=$secrets
12831287

@@ -1290,9 +1294,10 @@ check_passwords_leak() {
12901294
pods=$(kubectl_bin get pods -o name | awk -F "/" '{print $2}')
12911295
echo pods=$pods
12921296

1293-
TEMP_DIR=$(mktemp -d)
1294-
12951297
collect_logs() {
1298+
local containers
1299+
local count
1300+
12961301
NS=$1
12971302
for p in $pods; do
12981303
containers=$(kubectl_bin -n "$NS" get pod $p -o jsonpath='{.spec.containers[*].name}')
@@ -1301,12 +1306,12 @@ check_passwords_leak() {
13011306
if [[ ${c} =~ "pmm" ]]; then
13021307
continue
13031308
fi
1304-
kubectl_bin -n "$NS" logs $p -c $c >${TEMP_DIR}/logs_output-$p-$c.txt
1305-
echo logs saved in: ${TEMP_DIR}/logs_output-$p-$c.txt
1309+
kubectl_bin -n "$NS" logs $p -c $c >${tmp_dir}/logs_output-$p-$c.txt
1310+
echo logs saved in: ${tmp_dir}/logs_output-$p-$c.txt
13061311
for pass in $passwords; do
1307-
count=$(grep -c --fixed-strings -- "$pass" ${TEMP_DIR}/logs_output-$p-$c.txt || :)
1312+
count=$(grep -c --fixed-strings -- "$pass" ${tmp_dir}/logs_output-$p-$c.txt || :)
13081313
if [[ $count != 0 ]]; then
1309-
echo leaked passwords are found in log ${TEMP_DIR}/logs_output-$p-$c.txt
1314+
echo leaked passwords are found in log ${tmp_dir}/logs_output-$p-$c.txt
13101315
false
13111316
fi
13121317
done

e2e-tests/init-deploy/compare/backup-50.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,6 @@
387387
},
388388
"actions": [
389389
"appendOplogNote",
390-
"checkFreeMonitoringStatus",
391390
"connPoolStats",
392391
"forceUUID",
393392
"getDefaultRWConcern",

e2e-tests/init-deploy/compare/clusterAdmin-50.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@
219219
"appendOplogNote",
220220
"applicationMessage",
221221
"auditConfigure",
222-
"checkFreeMonitoringStatus",
223222
"cleanupOrphaned",
224223
"connPoolStats",
225224
"connPoolSync",
@@ -256,7 +255,6 @@
256255
"serverStatus",
257256
"setDefaultRWConcern",
258257
"setFeatureCompatibilityVersion",
259-
"setFreeMonitoring",
260258
"setParameter",
261259
"shardingState",
262260
"shutdown",

e2e-tests/init-deploy/compare/clusterMonitor-50.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@
156156
"cluster": true
157157
},
158158
"actions": [
159-
"checkFreeMonitoringStatus",
160159
"connPoolStats",
161160
"getDefaultRWConcern",
162161
"getCmdLineOpts",

e2e-tests/monitoring-2-0/run

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ else
3232
retry 10 60 helm install monitoring --set imageTag=$IMAGE_PMM_SERVER_TAG --set imageRepo=$IMAGE_PMM_SERVER_REPO --set platform=$platform https://percona-charts.storage.googleapis.com/pmm-server-${PMM_SERVER_VER}.tgz
3333
fi
3434
sleep 20
35-
SERVICE="postgres"
36-
until kubectl_bin exec monitoring-0 -- bash -c "pgrep -x $SERVICE >/dev/null"; do
35+
until kubectl_bin exec monitoring-0 -- bash -c "ls -l /proc/*/exe 2>/dev/null| grep postgres >/dev/null"; do
3736
echo "Retry $retry"
3837
sleep 5
3938
let retry+=1

0 commit comments

Comments
 (0)