Skip to content

Commit 82a1d97

Browse files
nmarukovichhors
andauthored
K8SPSMDB-754 update logs level (#1683)
Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>
1 parent 8a063f4 commit 82a1d97

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

pkg/apis/psmdb/v1/psmdb_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ func (m *MultiAZ) WithSidecarVolumes(log logr.Logger, volumes []corev1.Volume) [
410410

411411
for _, v := range m.SidecarVolumes {
412412
if _, ok := names[v.Name]; ok {
413-
log.Info("Wrong sidecar volume name, it is skipped", "volumeName", v.Name)
413+
log.Error(errors.New("Wrong sidecar volume name, it is skipped"), "volumeName", v.Name)
414414
continue
415415
}
416416

@@ -431,7 +431,7 @@ func (m *MultiAZ) WithSidecarPVCs(log logr.Logger, pvcs []corev1.PersistentVolum
431431

432432
for _, p := range m.SidecarPVCs {
433433
if _, ok := names[p.Name]; ok {
434-
log.Info("Wrong sidecar PVC name, it is skipped", "PVCName", p.Name)
434+
log.Error(errors.New("Wrong sidecar PVC name, it is skipped"), "PVCName", p.Name)
435435
continue
436436
}
437437

pkg/controller/perconaservermongodb/finalizers.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ func (r *ReconcilePerconaServerMongoDB) deletePSMDBPods(ctx context.Context, cr
120120
rsDeleted = false
121121
switch err {
122122
case errWaitingTermination, errWaitingFirstPrimary:
123-
log.Info(err.Error(), "rs", rs.Name)
123+
log.Error(err, "rs", rs.Name)
124124
continue
125125
default:
126126
log.Error(err, "failed to delete rs pods", "rs", rs.Name)

pkg/controller/perconaservermongodb/users.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ func (r *ReconcilePerconaServerMongoDB) reconcileUsers(ctx context.Context, cr *
4040
}
4141

4242
if !cr.Spec.PMM.HasSecret(&sysUsersSecretObj) && cr.Spec.PMM.Enabled {
43-
log.Info(fmt.Sprintf(`Can't enable PMM: "%s" or "%s" with "%s" keys don't exist in the secrets, or secrets and internal secrets are out of sync`,
44-
api.PMMAPIKey, api.PMMUserKey, api.PMMPasswordKey), "secrets", cr.Spec.Secrets.Users, "internalSecrets", api.InternalUserSecretName(cr))
43+
log.Error(errors.New(fmt.Sprintf(`Can't enable PMM: "%s" or "%s" with "%s" keys don't exist in the secrets, or secrets and internal secrets are out of sync`,
44+
api.PMMAPIKey, api.PMMUserKey, api.PMMPasswordKey)), "secrets", cr.Spec.Secrets.Users, "internalSecrets", api.InternalUserSecretName(cr))
4545
}
4646

4747
secretName := api.InternalUserSecretName(cr)

pkg/psmdb/tls/certmanager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ func (c *certManagerController) Check(ctx context.Context, config *rest.Config,
240240
case cmapichecker.ErrCertManagerCRDsNotFound:
241241
return ErrCertManagerNotFound
242242
case cmapichecker.ErrWebhookCertificateFailure, cmapichecker.ErrWebhookServiceFailure, cmapichecker.ErrWebhookDeploymentFailure:
243-
log.Info("cert-manager is not ready", "error", cmapichecker.TranslateToSimpleError(err))
243+
log.Error(cmapichecker.TranslateToSimpleError(err), "cert-manager is not ready")
244244
return ErrCertManagerNotReady
245245
}
246246
return err

0 commit comments

Comments
 (0)