K8SPSMDB-872: don't restore a backup with error state (#1266)

pooknull · inelpandzic · web-flow · commit 8483d1b2b3ff · 2023-08-15T15:37:14.000+03:00
https://jira.percona.com/browse/K8SPSMDB-872 Co-authored-by: Inel Pandzic <inel.pandzic@percona.com>
diff --git a/pkg/controller/perconaservermongodbrestore/perconaservermongodbrestore_controller.go b/pkg/controller/perconaservermongodbrestore/perconaservermongodbrestore_controller.go
@@ -146,7 +146,12 @@ func (r *ReconcilePerconaServerMongoDBRestore) Reconcile(ctx context.Context, re
 		return rr, errors.Wrap(err, "get backup")
 	}
 
-	if bcp.Status.State != psmdbv1.BackupStateReady {
+	switch bcp.Status.State {
+	case psmdbv1.BackupStateError:
+		err = errors.New("backup is in error state")
+		return rr, nil
+	case psmdbv1.BackupStateReady:
+	default:
 		return reconcile.Result{}, errors.New("backup is not ready")
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,12 @@ func (r *ReconcilePerconaServerMongoDBRestore) Reconcile(ctx context.Context, re`
`146`	`146`	`return rr, errors.Wrap(err, "get backup")`
`147`	`147`	`}`
`148`	`148`
`149`		`- if bcp.Status.State != psmdbv1.BackupStateReady {`
	`149`	`+ switch bcp.Status.State {`
	`150`	`+ case psmdbv1.BackupStateError:`
	`151`	`+ err = errors.New("backup is in error state")`
	`152`	`+ return rr, nil`
	`153`	`+ case psmdbv1.BackupStateReady:`
	`154`	`+ default:`
`150`	`155`	`return reconcile.Result{}, errors.New("backup is not ready")`
`151`	`156`	`}`
`152`	`157`