K8SPSMDB-991 - Add PMM_AGENT_PATHS_TEMPDIR env var for pmm-agent sidecar (#1350)

* K8SPSMDB-991 - Add PMM_AGENT_PATHS_TEMPDIR env var for pmm-agent sidecar

* K8SPSMDB-991 - Update PMM_AGENT_PATHS_TEMPDIR to /data/db/pmm2/tmp

* Set PMM_AGENT_PATHS_TEMPDIR to /tmp

* Set PMM_AGENT_PATHS_TEMPDIR only if crVersion >= 1.15.0

* Fix monitoring and default-cr test for openshift

Author: tplavcic

e2e-tests/default-cr/run

@@ -110,7 +110,17 @@ function main() {
 			"spec": {"pmm":{"enabled":false}}
 		}'
 	sleep 120
+
+	if [[ -n ${OPENSHIFT} ]]; then
+		oc adm policy remove-scc-from-user privileged -z pmm-server
+		if [ -n "$OPERATOR_NS" ]; then
+			oc delete clusterrolebinding pmm-psmdb-operator-cluster-wide
+		else
+			oc delete rolebinding pmm-psmdb-operator-namespace-only
+		fi
+	fi
 	helm uninstall monitoring
+
 	wait_cluster_consistency $cluster
 
 	desc 'enabling arbiter'

e2e-tests/monitoring-2-0/compare/statefulset_monitoring-cfg-oc.yml

@@ -232,6 +232,8 @@ spec:
               value: "true"
             - name: PMM_AGENT_SIDECAR_SLEEP
               value: "5"
+            - name: PMM_AGENT_PATHS_TEMPDIR
+              value: /tmp
           imagePullPolicy: Always
           lifecycle:
             preStop:

e2e-tests/monitoring-2-0/compare/statefulset_monitoring-cfg.yml

@@ -233,6 +233,8 @@ spec:
               value: "true"
             - name: PMM_AGENT_SIDECAR_SLEEP
               value: "5"
+            - name: PMM_AGENT_PATHS_TEMPDIR
+              value: /tmp
           imagePullPolicy: Always
           lifecycle:
             preStop:

e2e-tests/monitoring-2-0/compare/statefulset_monitoring-mongos-oc.yml

@@ -234,6 +234,8 @@ spec:
               value: "true"
             - name: PMM_AGENT_SIDECAR_SLEEP
               value: "5"
+            - name: PMM_AGENT_PATHS_TEMPDIR
+              value: /tmp
           imagePullPolicy: Always
           lifecycle:
             preStop:

e2e-tests/monitoring-2-0/compare/statefulset_monitoring-mongos.yml

@@ -235,6 +235,8 @@ spec:
               value: "true"
             - name: PMM_AGENT_SIDECAR_SLEEP
               value: "5"
+            - name: PMM_AGENT_PATHS_TEMPDIR
+              value: /tmp
           imagePullPolicy: Always
           lifecycle:
             preStop:

e2e-tests/monitoring-2-0/compare/statefulset_monitoring-rs0-oc.yml

@@ -220,6 +220,8 @@ spec:
               value: "true"
             - name: PMM_AGENT_SIDECAR_SLEEP
               value: "5"
+            - name: PMM_AGENT_PATHS_TEMPDIR
+              value: /tmp
           imagePullPolicy: Always
           lifecycle:
             preStop:

e2e-tests/monitoring-2-0/compare/statefulset_monitoring-rs0.yml

@@ -221,6 +221,8 @@ spec:
               value: "true"
             - name: PMM_AGENT_SIDECAR_SLEEP
               value: "5"
+            - name: PMM_AGENT_PATHS_TEMPDIR
+              value: /tmp
           imagePullPolicy: Always
           lifecycle:
             preStop:

e2e-tests/monitoring-2-0/run

@@ -114,7 +114,12 @@ get_qan_values mongodb "dev-mongod" admin:admin
 get_qan_values mongodb "dev-mongos" admin:admin
 
 if [[ -n ${OPENSHIFT} ]]; then
-	oc adm policy remove-scc-from-user privileged -z percona-server-mongodb-operator
+	oc adm policy remove-scc-from-user privileged -z pmm-server
+	if [ -n "$OPERATOR_NS" ]; then
+		oc delete clusterrolebinding pmm-psmdb-operator-cluster-wide
+	else
+		oc delete rolebinding pmm-psmdb-operator-namespace-only
+	fi
 fi
 
 if [[ $(kubectl_bin logs monitoring-rs0-0 pmm-client | grep -c 'cannot auto discover databases and collections') != 0 ]]; then

pkg/psmdb/pmm.go

@@ -374,6 +374,17 @@ func AddPMMContainer(ctx context.Context, cr *api.PerconaServerMongoDB, secret *
 		}
 		pmmC.Env = append(pmmC.Env, sidecarEnvs...)
 	}
+	if cr.CompareVersion("1.15.0") >= 0 {
+		// PMM team moved temp directory to /usr/local/percona/pmm2/tmp
+		// but it doesn't work on OpenShift so we set it back to /tmp
+		sidecarEnvs := []corev1.EnvVar{
+			{
+				Name:  "PMM_AGENT_PATHS_TEMPDIR",
+				Value: "/tmp",
+			},
+		}
+		pmmC.Env = append(pmmC.Env, sidecarEnvs...)
+	}
 
 	return &pmmC
 }