validation for autoscaling and unit test

Author: gkech

config/crd/bases/psmdb.percona.com_perconaservermongodbs.yaml

@@ -25399,6 +25399,11 @@ spec:
                   enableVolumeScaling:
                     type: boolean
                 type: object
+                x-kubernetes-validations:
+                - message: autoscaling cannot be enabled when enableVolumeScaling
+                    is disabled
+                  rule: '!has(self.autoscaling) || !has(self.autoscaling.enabled)
+                    || !self.autoscaling.enabled || self.enableVolumeScaling'
               tls:
                 properties:
                   allowInvalidCertificates:

deploy/bundle.yaml

@@ -26286,6 +26286,11 @@ spec:
                   enableVolumeScaling:
                     type: boolean
                 type: object
+                x-kubernetes-validations:
+                - message: autoscaling cannot be enabled when enableVolumeScaling
+                    is disabled
+                  rule: '!has(self.autoscaling) || !has(self.autoscaling.enabled)
+                    || !self.autoscaling.enabled || self.enableVolumeScaling'
               tls:
                 properties:
                   allowInvalidCertificates:

deploy/crd.yaml

@@ -26286,6 +26286,11 @@ spec:
                   enableVolumeScaling:
                     type: boolean
                 type: object
+                x-kubernetes-validations:
+                - message: autoscaling cannot be enabled when enableVolumeScaling
+                    is disabled
+                  rule: '!has(self.autoscaling) || !has(self.autoscaling.enabled)
+                    || !self.autoscaling.enabled || self.enableVolumeScaling'
               tls:
                 properties:
                   allowInvalidCertificates:

deploy/cw-bundle.yaml

@@ -26286,6 +26286,11 @@ spec:
                   enableVolumeScaling:
                     type: boolean
                 type: object
+                x-kubernetes-validations:
+                - message: autoscaling cannot be enabled when enableVolumeScaling
+                    is disabled
+                  rule: '!has(self.autoscaling) || !has(self.autoscaling.enabled)
+                    || !self.autoscaling.enabled || self.enableVolumeScaling'
               tls:
                 properties:
                   allowInvalidCertificates:

e2e-tests/version-service/conf/crd.yaml

@@ -26286,6 +26286,11 @@ spec:
                   enableVolumeScaling:
                     type: boolean
                 type: object
+                x-kubernetes-validations:
+                - message: autoscaling cannot be enabled when enableVolumeScaling
+                    is disabled
+                  rule: '!has(self.autoscaling) || !has(self.autoscaling.enabled)
+                    || !self.autoscaling.enabled || self.enableVolumeScaling'
               tls:
                 properties:
                   allowInvalidCertificates:

pkg/apis/psmdb/v1/psmdb_types.go

@@ -1012,6 +1012,7 @@ type StorageAutoscalingStatus struct {
 }
 
 // StorageScalingSpec defines the configuration for storage scaling behavior
+// +kubebuilder:validation:XValidation:rule="!has(self.autoscaling) || !has(self.autoscaling.enabled) || !self.autoscaling.enabled || self.enableVolumeScaling",message="autoscaling cannot be enabled when enableVolumeScaling is disabled"
 type StorageScalingSpec struct {
 	// EnableExternalAutoscaling delegates volume autoscaling to an external system (e.g., Kubernetes VPA)
 	// When enabled, the operator skips internal autoscaling and resize operations

pkg/controller/perconaservermongodb/psmdb_controller_test.go

@@ -9,6 +9,8 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
+
+	psmdbv1 "github.com/percona/percona-server-mongodb-operator/pkg/apis/psmdb/v1"
 )
 
 var _ = Describe("PerconaServerMongoDB", Ordered, func() {
@@ -52,3 +54,58 @@ var _ = Describe("PerconaServerMongoDB", Ordered, func() {
 		Expect(err).To(Succeed())
 	})
 })
+
+var _ = Describe("PerconaServerMongoDB CRD Validation", Ordered, func() {
+	ctx := context.Background()
+	const ns = "psmdb-validation"
+	namespace := &corev1.Namespace{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      ns,
+			Namespace: ns,
+		},
+	}
+
+	BeforeAll(func() {
+		By("Creating the Namespace to perform the tests")
+		err := k8sClient.Create(ctx, namespace)
+		Expect(err).To(Not(HaveOccurred()))
+	})
+
+	AfterAll(func() {
+		By("Deleting the Namespace to perform the tests")
+		_ = k8sClient.Delete(ctx, namespace)
+	})
+
+	Context("StorageScaling validation", func() {
+		It("should reject autoscaling enabled when enableVolumeScaling is disabled", func() {
+			cr, err := readDefaultCR("psmdb-invalid-autoscaling", ns)
+			Expect(err).NotTo(HaveOccurred())
+
+			cr.Spec.StorageScaling = &psmdbv1.StorageScalingSpec{
+				EnableVolumeScaling: false,
+				Autoscaling: &psmdbv1.AutoscalingSpec{
+					Enabled: true,
+				},
+			}
+
+			err = k8sClient.Create(ctx, cr)
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("autoscaling cannot be enabled when enableVolumeScaling is disabled"))
+		})
+
+		It("should allow autoscaling enabled when enableVolumeScaling is enabled", func() {
+			cr, err := readDefaultCR("psmdb-valid-autoscaling", ns)
+			Expect(err).NotTo(HaveOccurred())
+
+			cr.Spec.StorageScaling = &psmdbv1.StorageScalingSpec{
+				EnableVolumeScaling: true,
+				Autoscaling: &psmdbv1.AutoscalingSpec{
+					Enabled: true,
+				},
+			}
+
+			err = k8sClient.Create(ctx, cr)
+			Expect(err).NotTo(HaveOccurred())
+		})
+	})
+})