K8SPS-341: ignore delete-backup finalizer for not finished backups (#654)

https://perconadev.atlassian.net/browse/K8SPS-341

Co-authored-by: Viacheslav Sarzhan <[email protected]>

Author: pooknull

pkg/controller/psbackup/controller.go

@@ -519,6 +519,10 @@ func (r *PerconaServerMySQLBackupReconciler) backupConfig(ctx context.Context, c
 }
 
 func (r *PerconaServerMySQLBackupReconciler) deleteBackup(ctx context.Context, cr *apiv1alpha1.PerconaServerMySQLBackup) (bool, error) {
+	if cr.Status.State != apiv1alpha1.BackupSucceeded {
+		return true, nil
+	}
+
 	backupConf, err := r.backupConfig(ctx, cr)
 	if err != nil {
 		return false, errors.Wrap(err, "failed to create sidecar backup config")

pkg/controller/psbackup/controller_test.go

@@ -226,7 +226,7 @@ func TestCheckFinalizers(t *testing.T) {
 				cr.Status.State = apiv1alpha1.BackupFailed
 			}),
 			finalizerJobFail:   true,
-			expectedFinalizers: []string{naming.FinalizerDeleteBackup},
+			expectedFinalizers: []string{},
 		},
 		{
 			name: "with successful finalizer and failed state",