Skip to content

Commit 17b1fd8

Browse files
inelpandzichors
andauthored
K8SPS-270: Logging improvements (#334)
* ps-controller name. * Named controller. * Cleanup --------- Co-authored-by: Viacheslav Sarzhan <[email protected]>
1 parent 7128bf9 commit 17b1fd8

File tree

4 files changed

+5
-2
lines changed

4 files changed

+5
-2
lines changed

cmd/manager/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ func main() {
118118
Scheme: mgr.GetScheme(),
119119
ServerVersion: serverVersion,
120120
}).SetupWithManager(mgr); err != nil {
121-
setupLog.Error(err, "unable to create controller", "controller", "PerconaServerMySQL")
121+
setupLog.Error(err, "unable to create controller", "controller", "ps-controller")
122122
os.Exit(1)
123123
}
124124
if err = (&psbackup.PerconaServerMySQLBackupReconciler{

pkg/controller/ps/controller.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ type PerconaServerMySQLReconciler struct {
7373
func (r *PerconaServerMySQLReconciler) SetupWithManager(mgr ctrl.Manager) error {
7474
return ctrl.NewControllerManagedBy(mgr).
7575
For(&apiv1alpha1.PerconaServerMySQL{}).
76+
Named("ps-controller").
7677
Complete(r)
7778
}
7879

@@ -89,7 +90,7 @@ func (r *PerconaServerMySQLReconciler) Reconcile(
8990
ctx context.Context,
9091
req ctrl.Request,
9192
) (ctrl.Result, error) {
92-
log := logf.FromContext(ctx).WithName("PerconaServerMySQL")
93+
log := logf.FromContext(ctx)
9394

9495
rr := ctrl.Result{RequeueAfter: 5 * time.Second}
9596

pkg/controller/psbackup/controller.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ type PerconaServerMySQLBackupReconciler struct {
6363
func (r *PerconaServerMySQLBackupReconciler) SetupWithManager(mgr ctrl.Manager) error {
6464
return ctrl.NewControllerManagedBy(mgr).
6565
For(&apiv1alpha1.PerconaServerMySQLBackup{}).
66+
Named("psbackup-controller").
6667
Complete(r)
6768
}
6869

pkg/controller/psrestore/controller.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,7 @@ func (r *PerconaServerMySQLRestoreReconciler) unpauseCluster(ctx context.Context
439439
func (r *PerconaServerMySQLRestoreReconciler) SetupWithManager(mgr ctrl.Manager) error {
440440
return ctrl.NewControllerManagedBy(mgr).
441441
For(&apiv1alpha1.PerconaServerMySQLRestore{}).
442+
Named("psrestore-controller").
442443
Owns(&batchv1.Job{}).
443444
Complete(r)
444445
}

0 commit comments

Comments
 (0)