K8SPS-413: replace initImage with initContainer (#996)

* K8SPS-413: replace initImage with initContainer

https://perconadev.atlassian.net/browse/K8SPS-413

* fix test

* add test

* make generate

* replace all initImage fields with initContainer

* add version checks

* fix unit-test

* add nolint comments

* update controller-gen to v0.18.0

* improve Jenkinsfile

* improve Jenkinsfile

---------

Co-authored-by: Viacheslav Sarzhan <[email protected]>

Author: pooknull

Jenkinsfile

@@ -248,7 +248,10 @@ void runTest(Integer TEST_ID) {
 
 void prepareNode() {
     sh """
-        sudo curl -s -L -o /usr/local/bin/kubectl https://dl.k8s.io/release/\$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl && sudo chmod +x /usr/local/bin/kubectl
+        if [ ! -f /usr/local/bin/kubectl ]; then
+            sudo curl -s -L -o /usr/local/bin/kubectl https://dl.k8s.io/release/\$(curl -L -s https://api.github.com/repos/kubernetes/kubernetes/releases/latest | jq -r .tag_name)/bin/linux/amd64/kubectl && sudo chmod +x /usr/local/bin/kubectl
+        fi
+
         kubectl version --client --output=yaml
 
         curl -fsSL https://get.helm.sh/helm-v3.18.0-linux-amd64.tar.gz | sudo tar -C /usr/local/bin --strip-components 1 -xzf - linux-amd64/helm

api/v1alpha1/perconaservermysql_types.go

@@ -63,7 +63,6 @@ type PerconaServerMySQLSpec struct {
 	SecretsName            string                               `json:"secretsName,omitempty"`
 	SSLSecretName          string                               `json:"sslSecretName,omitempty"`
 	Unsafe                 UnsafeFlags                          `json:"unsafeFlags,omitempty"`
-	InitImage              string                               `json:"initImage,omitempty"`
 	IgnoreAnnotations      []string                             `json:"ignoreAnnotations,omitempty"`
 	IgnoreLabels           []string                             `json:"ignoreLabels,omitempty"`
 	MySQL                  MySQLSpec                            `json:"mysql,omitempty"`
@@ -75,6 +74,16 @@ type PerconaServerMySQLSpec struct {
 	Toolkit                *ToolkitSpec                         `json:"toolkit,omitempty"`
 	UpgradeOptions         UpgradeOptions                       `json:"upgradeOptions,omitempty"`
 	UpdateStrategy         appsv1.StatefulSetUpdateStrategyType `json:"updateStrategy,omitempty"`
+
+	// Deprecated: not supported since v0.12.0. Use initContainer instead
+	InitImage     string            `json:"initImage,omitempty"`
+	InitContainer InitContainerSpec `json:"initContainer,omitempty"`
+}
+
+type InitContainerSpec struct {
+	Image                    string                       `json:"image,omitempty"`
+	Resources                *corev1.ResourceRequirements `json:"resources,omitempty"`
+	ContainerSecurityContext *corev1.SecurityContext      `json:"containerSecurityContext,omitempty"`
 }
 
 type UnsafeFlags struct {
@@ -178,7 +187,10 @@ type PodSpec struct {
 	Annotations map[string]string `json:"annotations,omitempty"`
 	Labels      map[string]string `json:"labels,omitempty"`
 	VolumeSpec  *VolumeSpec       `json:"volumeSpec,omitempty"`
-	InitImage   string            `json:"initImage,omitempty"`
+
+	// Deprecated: not supported since v0.12.0. Use initContainer instead
+	InitImage     string             `json:"initImage,omitempty"`
+	InitContainer *InitContainerSpec `json:"initContainer,omitempty"`
 
 	Affinity                      *PodAffinity                      `json:"affinity,omitempty"`
 	TopologySpreadConstraints     []corev1.TopologySpreadConstraint `json:"topologySpreadConstraints,omitempty"`
@@ -208,9 +220,16 @@ func (s PodSpec) GetTerminationGracePeriodSeconds() *int64 {
 	return &gp
 }
 
-// Retrieves the initialization image for the pod.
-func (s *PodSpec) GetInitImage() string {
-	return s.InitImage
+func (s *PodSpec) GetInitSpec(cr *PerconaServerMySQL) InitContainerSpec {
+	if s.InitContainer == nil {
+		if cr.CompareVersion("0.12.0") < 0 {
+			return InitContainerSpec{
+				Image: s.InitImage,
+			}
+		}
+		return InitContainerSpec{}
+	}
+	return *s.InitContainer
 }
 
 type PMMSpec struct {
@@ -226,7 +245,6 @@ type PMMSpec struct {
 type BackupSpec struct {
 	Enabled                  bool                          `json:"enabled,omitempty"`
 	Image                    string                        `json:"image"`
-	InitImage                string                        `json:"initImage,omitempty"`
 	ImagePullSecrets         []corev1.LocalObjectReference `json:"imagePullSecrets,omitempty"`
 	ImagePullPolicy          corev1.PullPolicy             `json:"imagePullPolicy,omitempty"`
 	ServiceAccountName       string                        `json:"serviceAccountName,omitempty"`
@@ -236,6 +254,10 @@ type BackupSpec struct {
 	BackoffLimit             *int32                        `json:"backoffLimit,omitempty"`
 	PiTR                     PiTRSpec                      `json:"pitr,omitempty"`
 	Schedule                 []BackupSchedule              `json:"schedule,omitempty"`
+
+	// Deprecated: not supported since v0.12.0. Use initContainer instead
+	InitImage     string             `json:"initImage,omitempty"`
+	InitContainer *InitContainerSpec `json:"initContainer,omitempty"`
 }
 
 type BackupSchedule struct {
@@ -248,9 +270,16 @@ type BackupSchedule struct {
 	StorageName string `json:"storageName,omitempty"`
 }
 
-// Retrieves the initialization image for the backup.
-func (s *BackupSpec) GetInitImage() string {
-	return s.InitImage
+func (s *BackupSpec) GetInitSpec(cr *PerconaServerMySQL) InitContainerSpec {
+	if s.InitContainer == nil {
+		if cr.CompareVersion("0.12.0") < 0 {
+			return InitContainerSpec{
+				Image: s.InitImage,
+			}
+		}
+		return InitContainerSpec{}
+	}
+	return *s.InitContainer
 }
 
 type BackupStorageType string