K8SPS-263: set error state if invalid issuer is used (#401)

* K8SPS-263: set error state if invalid issuer is used

https://jira.percona.com/browse/K8SPS-263

* fix problem with `r.allLoadBalancersReady()`

* fix merge

* fix `golangci-lint`

* update `status_test.go`

Author: pooknull

cmd/manager/main.go

@@ -39,6 +39,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 
 	apiv1alpha1 "github.com/percona/percona-server-mysql-operator/api/v1alpha1"
+	"github.com/percona/percona-server-mysql-operator/pkg/clientcmd"
 	"github.com/percona/percona-server-mysql-operator/pkg/controller/ps"
 	"github.com/percona/percona-server-mysql-operator/pkg/controller/psbackup"
 	"github.com/percona/percona-server-mysql-operator/pkg/controller/psrestore"
@@ -102,7 +103,13 @@ func main() {
 
 	nsClient := client.NewNamespacedClient(mgr.GetClient(), ns)
 
-	serverVersion, err := platform.GetServerVersion()
+	cliCmd, err := clientcmd.NewClient()
+	if err != nil {
+		setupLog.Error(err, "unable to create clientcmd")
+		os.Exit(1)
+	}
+
+	serverVersion, err := platform.GetServerVersion(cliCmd)
 	if err != nil {
 		setupLog.Error(err, "unable to get server version")
 		os.Exit(1)
@@ -118,6 +125,7 @@ func main() {
 		Scheme:        mgr.GetScheme(),
 		ServerVersion: serverVersion,
 		Recorder:      mgr.GetEventRecorderFor("ps-controller"),
+		ClientCmd:     cliCmd,
 	}).SetupWithManager(mgr); err != nil {
 		setupLog.Error(err, "unable to create controller", "controller", "ps-controller")
 		os.Exit(1)

cmd/orc-handler/main.go

@@ -19,6 +19,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 
 	apiv1alpha1 "github.com/percona/percona-server-mysql-operator/api/v1alpha1"
+	perconaClientCmd "github.com/percona/percona-server-mysql-operator/pkg/clientcmd"
 	"github.com/percona/percona-server-mysql-operator/pkg/k8s"
 	"github.com/percona/percona-server-mysql-operator/pkg/mysql"
 	"github.com/percona/percona-server-mysql-operator/pkg/platform"
@@ -88,7 +89,12 @@ func setPrimaryLabel(ctx context.Context, primary string) error {
 		return err
 	}
 
-	serverVersion, err := platform.GetServerVersion()
+	cliCmd, err := perconaClientCmd.NewClient()
+	if err != nil {
+		return err
+	}
+
+	serverVersion, err := platform.GetServerVersion(cliCmd)
 	if err != nil {
 		return err
 	}

pkg/clientcmd/clientcmd.go

@@ -12,12 +12,17 @@ import (
 	"k8s.io/client-go/tools/remotecommand"
 )
 
-type Client struct {
+type client struct {
 	client     corev1client.CoreV1Interface
 	restconfig *restclient.Config
 }
 
-func NewClient() (*Client, error) {
+type Client interface {
+	Exec(ctx context.Context, pod *corev1.Pod, containerName string, command []string, stdin io.Reader, stdout, stderr io.Writer, tty bool) error
+	REST() restclient.Interface
+}
+
+func NewClient() (Client, error) {
 	// Instantiate loader for kubeconfig file.
 	kubeconfig := clientcmd.NewNonInteractiveDeferredLoadingClientConfig(
 		clientcmd.NewDefaultClientConfigLoadingRules(),
@@ -39,13 +44,13 @@ func NewClient() (*Client, error) {
 		return nil, err
 	}
 
-	return &Client{
+	return &client{
 		client:     cl,
 		restconfig: restconfig,
 	}, nil
 }
 
-func (c *Client) Exec(
+func (c *client) Exec(
 	ctx context.Context,
 	pod *corev1.Pod,
 	containerName string,
@@ -84,6 +89,6 @@ func (c *Client) Exec(
 
 }
 
-func (c *Client) REST() restclient.Interface {
+func (c *client) REST() restclient.Interface {
 	return c.client.RESTClient()
 }