Skip to content

K8SPS-358: Add MySQL 8.4 support#871

Merged
hors merged 14 commits intomainfrom
K8SPS-425
Jun 16, 2025
Merged

K8SPS-358: Add MySQL 8.4 support#871
hors merged 14 commits intomainfrom
K8SPS-425

Conversation

@egegunes
Copy link
Copy Markdown
Contributor

@egegunes egegunes commented Mar 25, 2025

K8SPS-425 Powered by Pull Request Badge

CHANGE DESCRIPTION

This PR adds MySQL 8.4 support to operator.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/XXL 1000+ lines label Mar 25, 2025
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change
if [[ "$MYSQL_VERSION" != '8.0' ]] && [[ "${MYSQL_VERSION}" != '8.4' ]]; then
if [[ $MYSQL_VERSION != '8.0' ]] && [[ ${MYSQL_VERSION} != '8.4' ]]; then

@egegunes egegunes marked this pull request as ready for review June 12, 2025 07:41
@egegunes egegunes added this to the v0.11.0 milestone Jun 12, 2025
gkech
gkech previously approved these changes Jun 12, 2025
Copy link
Copy Markdown
Contributor

@gkech gkech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkech
Copy link
Copy Markdown
Contributor

gkech commented Jun 12, 2025

I guess this PR: #676 can be closed then?

pooknull
pooknull previously approved these changes Jun 13, 2025
@gkech gkech dismissed stale reviews from pooknull and themself via 001bc7a June 16, 2025 09:34
@gkech gkech requested review from gkech and pooknull June 16, 2025 09:35
@gkech
Copy link
Copy Markdown
Contributor

gkech commented Jun 16, 2025

version service test after the regex fix, when executed locally

Screenshot 2025-06-16 at 12 33 01 PM

@JNKPercona
Copy link
Copy Markdown
Collaborator

Test name Status
version-service passed
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-scheduled-backup passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
scheduled-backup passed
service-per-pod passed
sidecars passed
smart-update passed
tls-cert-manager passed
users passed
We run 34 out of 34

commit: 001bc7a
image: perconalab/percona-server-mysql-operator:PR-871-001bc7a8

@hors hors merged commit 3e02a39 into main Jun 16, 2025
14 of 16 checks passed
@hors hors deleted the K8SPS-425 branch June 16, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL 1000+ lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants