Bug#37512477 LQH_TRANSCONF signal printer crashes

There are currently two lengths of LQH_TRANSCONF used.

The signal printer should accomodate both, avoiding
printing uninitialised data and not making invalid
assertions about the supported signal lengths.

Change-Id: I0757b512445ae30c310b9c1ec37ed3ae2e1e4e38

Author: frazerclement

storage/ndb/include/kernel/signaldata/LqhTransConf.hpp

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2003, 2021, Oracle and/or its affiliates.
+   Copyright (c) 2003, 2025, Oracle and/or its affiliates.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License, version 2.0,
@@ -50,6 +50,7 @@ class LqhTransConf {
   friend bool printLQH_TRANSCONF(FILE *, const Uint32 *, Uint32, Uint16);  
 public:
   STATIC_CONST( SignalLength = 18 );
+  STATIC_CONST( MarkerSignalLength = 7 ) ;
 
   /**
    * Upgrade

storage/ndb/src/common/debugger/signaldata/LqhTrans.cpp

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2003, 2021, Oracle and/or its affiliates.
+   Copyright (c) 2003, 2025, Oracle and/or its affiliates.
     All rights reserved. Use is subject to license terms.
 
    This program is free software; you can redistribute it and/or modify
@@ -30,22 +30,26 @@ bool
 printLQH_TRANSCONF(FILE * output, const Uint32 * theData, 
 		   Uint32 len, Uint16 receiverBlockNo) {
   const LqhTransConf * const sig = (LqhTransConf *)theData;
-  fprintf(output, " tcRef: %x\n", sig->tcRef);
-  fprintf(output, " lqhNodeId: %x\n", sig->lqhNodeId);
-  fprintf(output, " operationStatus: %x\n", sig->operationStatus);
-  fprintf(output, " transId1: %x\n", sig->transId1);
-  fprintf(output, " transId2: %x\n", sig->transId2);
-  fprintf(output, " apiRef: %x\n", sig->apiRef);
-  fprintf(output, " apiOpRec: %x\n", sig->apiOpRec);
-  fprintf(output, " lqhConnectPtr: %x\n", sig->lqhConnectPtr);
-  fprintf(output, " oldTcOpRec: %x\n", sig->oldTcOpRec);
-  fprintf(output, " requestInfo: %x\n", sig->requestInfo);
-  fprintf(output, " gci_hi: %x\n", sig->gci_hi);
-  fprintf(output, " gci_lo: %x\n", sig->gci_lo);
-  fprintf(output, " nextNodeId1: %x\n", sig->nextNodeId1);
-  fprintf(output, " nextNodeId2: %x\n", sig->nextNodeId2);
-  fprintf(output, " nextNodeId3: %x\n", sig->nextNodeId3);
-  fprintf(output, " tableId: %x\n", sig->tableId);
+  if (len >= LqhTransConf::MarkerSignalLength) {
+    fprintf(output, " tcRef: %x\n", sig->tcRef);
+    fprintf(output, " lqhNodeId: %x\n", sig->lqhNodeId);
+    fprintf(output, " operationStatus: %x\n", sig->operationStatus);
+    fprintf(output, " transId1: %x\n", sig->transId1);
+    fprintf(output, " transId2: %x\n", sig->transId2);
+    fprintf(output, " apiRef: %x\n", sig->apiRef);
+    fprintf(output, " apiOpRec: %x\n", sig->apiOpRec);
+  }
+  if (len >= LqhTransConf::SignalLength) {
+    fprintf(output, " lqhConnectPtr: %x\n", sig->lqhConnectPtr);
+    fprintf(output, " oldTcOpRec: %x\n", sig->oldTcOpRec);
+    fprintf(output, " requestInfo: %x\n", sig->requestInfo);
+    fprintf(output, " gci_hi: %x\n", sig->gci_hi);
+    fprintf(output, " gci_lo: %x\n", sig->gci_lo);
+    fprintf(output, " nextNodeId1: %x\n", sig->nextNodeId1);
+    fprintf(output, " nextNodeId2: %x\n", sig->nextNodeId2);
+    fprintf(output, " nextNodeId3: %x\n", sig->nextNodeId3);
+    fprintf(output, " tableId: %x\n", sig->tableId);
+  }
   return true;
 }
 

storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2003, 2024, Oracle and/or its affiliates.
+   Copyright (c) 2003, 2025, Oracle and/or its affiliates.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License, version 2.0,
@@ -11945,8 +11945,8 @@ Dblqh::scanMarkers(Signal* signal,
       lqhTransConf->transId2 = iter.curr.p->transid2;
       lqhTransConf->apiRef   = iter.curr.p->apiRef;
       lqhTransConf->apiOpRec = iter.curr.p->apiOprec;
-      sendSignal(tcNodeFailPtr.p->newTcBlockref, GSN_LQH_TRANSCONF, 
-		 signal, 7, JBB);
+      sendSignal(tcNodeFailPtr.p->newTcBlockref, GSN_LQH_TRANSCONF, signal,
+                 LqhTransConf::MarkerSignalLength, JBB);
 
       signal->theData[0] = ZSCAN_MARKERS;
       signal->theData[1] = tcNodeFailPtr.i;