PS-9764 fix: Add clang-20 to Azure Pipelines and fix clang-20 compilation issues

percona-ysorokin · percona-ysorokin · commit 965081171e56 · 2025-05-06T22:56:28.000Z
https://perconadev.atlassian.net/browse/PS-9764 Fixed the following issue with calling 'memset()' on a nontrivially-constructed object ('TREE') by calling the placement new operator with empty brace initializer '{}' instead: /percona-server-8.0/storage/myisam/ft_boolean_search.cc:531:10: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'TREE' [-Werror,-Wnontrivial-memcall] 531 | memset(&ftb->no_dupes, 0, sizeof(TREE)); | ^ Fixed the following group of issues with calling 'memset()' on nontrivially-constructed objects ('TREE', 'MI_SORT_PARAM', 'MI_INFO') by declaring those objects with empty brace initializer '{}': /percona-server-8.0/storage/myisam/ft_nlq_search.cc:241:10: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'TREE' [-Werror,-Wnontrivial-memcall] 241 | memset(&wtree, 0, sizeof(wtree)); | ^ /home/yura/ws/percona-server-8.0/storage/myisam/myisamchk.cc:1404:10: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'MI_SORT_PARAM' [-Werror,-Wnontrivial-memcall] 1404 | memset(&sort_param, 0, sizeof(sort_param)); | ^ /home/yura/ws/percona-server-8.0/storage/myisam/mi_open.cc:122:10: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'MI_INFO' [-Werror,-Wnontrivial-memcall] 122 | memset(&info, 0, sizeof(info)); | ^ The following warning suppressed as it comes from the 'rocksdb' submodule code: /percona-server-8.0/storage/rocksdb/rocksdb/port/mmap.cc:46:15: error: first argument in call to 'memcpy' is a pointer to non-trivially copyable type 'rocksdb::MemMapping' [-Werror,-Wnontrivial-memcall] 46 | std::memcpy(this, &other, sizeof(*this)); | ^ Fixed the following literal operator warning: /percona-server-8.0/storage/temptable/include/temptable/constants.h:36:48: error: identifier '_KiB' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator] 36 | inline constexpr unsigned long long operator"" _KiB( | ~~~~~~~~~~~^~~~ | operator""_KiB Fixed the following extra semicolon warning in NDB code: /percona-server-8.0/storage/ndb/src/kernel/vm/Configuration.cpp:653:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi] 653 | }; | ^ Removed adding '-Wno-enum-constexpr-conversion' to the compiler options for clang >= 18 for 'sql_gis' as this option no longer exists in the 'clang-20' and Oracle fixed this issue properly in Bug #36292498 "Compile MySQL with clang 18 [noclose]" (commit mysql/mysql-server@5e066e70ebb).
diff --git a/sql/CMakeLists.txt b/sql/CMakeLists.txt
@@ -962,11 +962,6 @@ ADD_DEPENDENCIES(sql_gis GenError)
 TARGET_LINK_LIBRARIES(sql_gis sql_dd sql_main)
 SET_TARGET_PROPERTIES(sql_gis PROPERTIES LINK_INTERFACE_MULTIPLICITY 3)
 
-# Suppress warnings for clang-18 or newer
-IF(CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 18)
-  TARGET_COMPILE_OPTIONS(sql_gis PRIVATE -Wno-enum-constexpr-conversion)
-ENDIF()
-
 # This typically saves a few hundred megabytes of disk space.
 IF(COMPRESS_DEBUG_SECTIONS)
   MY_CHECK_CXX_COMPILER_FLAG("-gz" HAVE_COMPRESS_GZ_OPTION)
diff --git a/storage/myisam/ft_boolean_search.cc b/storage/myisam/ft_boolean_search.cc
@@ -528,7 +528,7 @@ FT_INFO *ft_init_boolean_search(MI_INFO *info, uint keynr, uchar *query,
   assert(keynr == NO_SUCH_KEY || cs == info->s->keyinfo[keynr].seg->charset);
   ftb->with_scan = 0;
   ftb->lastpos = HA_OFFSET_ERROR;
-  memset(&ftb->no_dupes, 0, sizeof(TREE));
+  ::new ((void *)&ftb->no_dupes) TREE{};
   ftb->last_word = nullptr;
 
   ::new ((void *)&ftb->mem_root) MEM_ROOT(PSI_INSTRUMENT_ME, 1024);
diff --git a/storage/myisam/ft_nlq_search.cc b/storage/myisam/ft_nlq_search.cc
@@ -217,7 +217,7 @@ static int FT_DOC_cmp(void *, uchar *a_arg, uchar *b_arg) {
 
 FT_INFO *ft_init_nlq_search(MI_INFO *info, uint keynr, uchar *query,
                             uint query_len, uint flags, uchar *record) {
-  TREE wtree;
+  TREE wtree{};
   ALL_IN_ONE aio;
   FT_DOC *dptr;
   st_ft_info_nlq *dlist = nullptr;
@@ -238,8 +238,6 @@ FT_INFO *ft_init_nlq_search(MI_INFO *info, uint keynr, uchar *query,
   parser = info->s->keyinfo[keynr].parser;
   if (!(ftparser_param = ftparser_call_initializer(info, keynr, 0))) goto err;
 
-  memset(&wtree, 0, sizeof(wtree));
-
   init_tree(&aio.dtree, 0, sizeof(FT_SUPERDOC), &FT_SUPERDOC_cmp, false,
             nullptr, nullptr);
 
diff --git a/storage/myisam/ft_update.cc b/storage/myisam/ft_update.cc
@@ -119,11 +119,10 @@ uint _mi_ft_parse(TREE *parsed, MI_INFO *info, uint keynr, const uchar *record,
 
 FT_WORD *_mi_ft_parserecord(MI_INFO *info, uint keynr, const uchar *record,
                             MEM_ROOT *mem_root) {
-  TREE ptree;
+  TREE ptree{};
   MYSQL_FTPARSER_PARAM *param;
   DBUG_TRACE;
   if (!(param = ftparser_call_initializer(info, keynr, 0))) return nullptr;
-  memset(&ptree, 0, sizeof(ptree));
   param->flags = 0;
   if (_mi_ft_parse(&ptree, info, keynr, record, param, mem_root))
     return nullptr;
diff --git a/storage/myisam/mi_check.cc b/storage/myisam/mi_check.cc
@@ -1412,11 +1412,10 @@ int mi_repair(MI_CHECK *param, MI_INFO *info, char *name, int rep_quick,
   MYISAM_SHARE *share = info->s;
   char llbuff[22], llbuff2[22];
   SORT_INFO sort_info;
-  MI_SORT_PARAM sort_param;
+  MI_SORT_PARAM sort_param{};
   DBUG_TRACE;
 
   memset(&sort_info, 0, sizeof(sort_info));
-  memset(&sort_param, 0, sizeof(sort_param));
   start_records = info->state->records;
   new_header_length =
       (param->testflag & T_UNPACK) ? 0L : share->pack.header_length;
@@ -2020,7 +2019,7 @@ int mi_repair_by_sort(MI_CHECK *param, MI_INFO *info, const char *name,
   ha_rows start_records;
   my_off_t new_header_length, del;
   File new_file;
-  MI_SORT_PARAM sort_param;
+  MI_SORT_PARAM sort_param{};
   MYISAM_SHARE *share = info->s;
   HA_KEYSEG *keyseg;
   ulong *rec_per_key_part;
@@ -2044,7 +2043,6 @@ int mi_repair_by_sort(MI_CHECK *param, MI_INFO *info, const char *name,
     param->testflag |= T_CALC_CHECKSUM;
 
   memset(&sort_info, 0, sizeof(sort_info));
-  memset(&sort_param, 0, sizeof(sort_param));
   if (!(sort_info.key_block =
             alloc_key_blocks(param, (uint)param->sort_key_blocks,
                              share->base.max_key_block_length)) ||
diff --git a/storage/myisam/mi_open.cc b/storage/myisam/mi_open.cc
@@ -106,7 +106,7 @@ MI_INFO *mi_open_share(const char *name, MYISAM_SHARE *old_share, int mode,
   char name_buff[FN_REFLEN], org_name[FN_REFLEN], index_name[FN_REFLEN],
       data_name[FN_REFLEN];
   uchar *disk_cache, *disk_pos, *end_pos;
-  MI_INFO info, *m_info;
+  MI_INFO info{}, *m_info;
   MYISAM_SHARE share_buff, *share;
   ulong rec_per_key_part[HA_MAX_POSSIBLE_KEY * MI_MAX_KEY_SEG];
   my_off_t key_root[HA_MAX_POSSIBLE_KEY], key_del[MI_MAX_KEY_BLOCK_SIZE];
@@ -119,7 +119,6 @@ MI_INFO *mi_open_share(const char *name, MYISAM_SHARE *old_share, int mode,
   lock_error = 1;
   errpos = 0;
   head_length = sizeof(share_buff.state.header);
-  memset(&info, 0, sizeof(info));
 
   realpath_err = my_realpath(
       name_buff, fn_format(org_name, name, "", MI_NAME_IEXT, 4), MYF(0));
diff --git a/storage/myisam/myisamchk.cc b/storage/myisam/myisamchk.cc
@@ -1397,11 +1397,10 @@ static int mi_sort_records(MI_CHECK *param, MI_INFO *info, char *name,
   MYISAM_SHARE *share = info->s;
   char llbuff[22], llbuff2[22];
   SORT_INFO sort_info;
-  MI_SORT_PARAM sort_param;
+  MI_SORT_PARAM sort_param{};
   DBUG_TRACE;
 
   memset(&sort_info, 0, sizeof(sort_info));
-  memset(&sort_param, 0, sizeof(sort_param));
   sort_param.sort_info = &sort_info;
   sort_info.param = param;
   keyinfo = &share->keyinfo[sort_key];
diff --git a/storage/ndb/src/kernel/vm/Configuration.cpp b/storage/ndb/src/kernel/vm/Configuration.cpp
@@ -650,15 +650,15 @@ void Configuration::setMixologyLevel(Uint32 l) { _mixologyLevel = l; }
 
 Uint32 Configuration::getShutdownHandlingFault() const {
   return _shutdownHandlingFault;
-};
+}
 Uint32 Configuration::getShutdownHandlingFaultExtra() const {
   return _shutdownHandlingFaultExtra;
-};
+}
 
 void Configuration ::setShutdownHandlingFault(Uint32 v, Uint32 extra) {
   _shutdownHandlingFault = v;
   _shutdownHandlingFaultExtra = extra;
-};
+}
 
 #endif
 
diff --git a/storage/rocksdb/CMakeLists.txt b/storage/rocksdb/CMakeLists.txt
@@ -229,6 +229,7 @@ IF(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
   remove_compile_flags(-Wdeprecated -Winconsistent-missing-destructor-override -Wnon-virtual-dtor)
   ADD_CXX_COMPILE_FLAGS_TO_FILES(-Wno-shadow-field FILES ha_rocksdb.cc rocksdb/memtable/hash_skiplist_rep.cc)
   ADD_CXX_COMPILE_FLAGS_TO_FILES(-Wno-conditional-uninitialized FILES ha_rocksdb.cc rdb_datadic.cc rocksdb/db/db_impl/db_impl.cc rocksdb/db/write_thread.cc rocksdb/env/env_posix.cc rocksdb/env/fs_posix.cc)
+  ADD_CXX_COMPILE_FLAGS_TO_FILES(-Wno-nontrivial-memcall FILES rocksdb/port/mmap.cc)
 ENDIF()
 
 # Suppress warnings for clang-9 or older
diff --git a/storage/temptable/include/temptable/constants.h b/storage/temptable/include/temptable/constants.h
@@ -33,23 +33,23 @@ namespace temptable {
 
 /** Multiply a number by 1024.
  * @return n * 1024. */
-inline constexpr unsigned long long operator"" _KiB(
+inline constexpr unsigned long long operator""_KiB(
     /** [in] Number to multiply. */
     unsigned long long n) {
   return n << 10;
 }
 
 /** Multiply a number by 1024 * 1024.
  * @return n * 1024 * 1024. */
-inline constexpr unsigned long long operator"" _MiB(
+inline constexpr unsigned long long operator""_MiB(
     /** [in] Number to multiply. */
     unsigned long long n) {
   return n << 20;
 }
 
 /** Multiply a number by 1024 * 1024 * 1024.
  * @return n * 1024 * 1024 * 1024. */
-inline constexpr unsigned long long operator"" _GiB(
+inline constexpr unsigned long long operator""_GiB(
     /** [in] Number to multiply. */
     unsigned long long n) {
   return n << 30;
diff --git a/unittest/gunit/temptable_allocator-t.cc b/unittest/gunit/temptable_allocator-t.cc
@@ -32,8 +32,8 @@ namespace temptable_allocator_unittest {
 
 // Needed for making it possible to use user-defined literals (e.g. 1_MiB) when
 // instantiating (generating) test-cases below
-using temptable::operator"" _KiB;
-using temptable::operator"" _MiB;
+using temptable::operator""_KiB;
+using temptable::operator""_MiB;
 
 /** GoogleTest macros for testing exceptions (EXPECT_THROW, EXPECT_NO_THROW,
  * EXPECT_ANY_THROW, etc.) do not provide direct means to inspect the value of
