Bug#37437317 : MySQL Server SEGV within: Table_ref::fetch_number_of_rows

Backport Bug#35647759 fix.

When a function is itemized the flags for the arguments are collected
first and *THEN* the arguments are itemized.
This doesn't account for certain Item itemizations that would replace
the item.
For these the flags aren't aggregated and INSTALL COMPONENT fails to
correctly detect and report the unsupported SET value expression types.

Fixed by itemizing the argument first and then collecting the flags.

Change-Id: I90e20da96aaf764c37b1db8c4ef332e85eb90b74

Author: Omar Sharieff

sql/item_func.cc

@@ -354,8 +354,8 @@ bool Item_func::itemize(Parse_context *pc, Item **res) {
   if (Item_result_field::itemize(pc, res)) return true;
   const bool no_named_params = !may_have_named_parameters();
   for (size_t i = 0; i < arg_count; i++) {
-    add_accum_properties(args[i]);
     if (args[i]->itemize(pc, &args[i])) return true;
+    add_accum_properties(args[i]);
     if (no_named_params && !args[i]->item_name.is_autogenerated()) {
       my_error(functype() == FUNC_SP ? ER_WRONG_PARAMETERS_TO_STORED_FCT
                                      : ER_WRONG_PARAMETERS_TO_NATIVE_FCT,