Document node_exporter collector customization and limitations #4782
+1,579
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-0
Link to the Feature Build: SUBMODULES-0
Description
Users need to customize node_exporter collectors (enable mdadm, configure netdev.address-info) but documentation is missing. Investigation revealed PMM only supports disabling collectors via
--disable-collectorsflag, not enabling disabled ones.Changes
Investigation artifacts (this repo):
NODE_EXPORTER_CUSTOMIZATION_FINDINGS.md- Technical analysis of node_exporter config inmanaged/services/agents/node.go, API (api/inventory/v1/agents.proto), and CLI (admin/commands/config.go)NODE_EXPORTER_DOCUMENTATION_README.md- User-facing summary with quick answerscreate-documentation-pr.sh- Helper script for pmm-doc PR creation0001-Document-node_exporter-collector-customization-v2.patch- Documentation changes for pmm-doc repoDocumentation created (pmm-doc repo at
/tmp/pmm-doc):docs/how-to/extend-metrics.md(+178 lines):--disable-collectorsflag usagedocs/details/commands/pmm-admin.md(+3 lines):--disable-collectorsflag topmm-admin configreferenceKey findings:
--no-collector.mdadmis hardcoded inmanaged/services/agents/node.go:91enable_collectorsAPI parameter exists--collector.netdev.address-infoExample usage:
Branch
document-node-exporter-customizationin/tmp/pmm-docready for PR to percona/pmm-doc.If this PR adds, removes or alters one or more API endpoints, please review and add or update the relevant API documentation as well:
If this PR is related to some other PRs in this or repositories, please provide links to those PRs:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.