Skip to content

Commit 8e72a39

Browse files
removed fallback for platformName
1 parent b370a23 commit 8e72a39

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

percy/providers/genericProvider.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ class GenericProvider {
249249
const element = elements[index];
250250

251251
const capabilities = await this.driver.getCapabilities();
252-
const PLATFORM_NAME = (capabilities.platformName || '').toLowerCase();
252+
const PLATFORM_NAME = capabilities.platformName.toLowerCase();
253253

254254
if (PLATFORM_NAME === 'android') {
255255
// Android identifiers

test/percy/providers/genericProvider.test.mjs

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -222,24 +222,6 @@ describe('GenericProvider', () => {
222222
expect(elementsArray).toEqual([{}]);
223223
});
224224

225-
it('should handle missing platformName in capabilities', async () => {
226-
mockDriver.getCapabilities.and.resolveTo({});
227-
const elementsArray = [];
228-
mockElement = {
229-
getAttribute: jasmine.createSpy('getAttribute')
230-
.and.returnValue('some-value')
231-
};
232-
233-
await provider.getRegionsByElements.call(
234-
{ driver: mockDriver, getRegionObject: getRegionObjectSpy },
235-
elementsArray,
236-
[mockElement]
237-
);
238-
239-
expect(getRegionObjectSpy).toHaveBeenCalledTimes(1);
240-
expect(getRegionObjectSpy.calls.argsFor(0)[0]).toBe('element: 0');
241-
expect(elementsArray).toEqual([{}]);
242-
});
243225
describe('Android', () => {
244226
beforeEach(() => {
245227
mockDriver.getCapabilities.and.resolveTo({ platformName: 'android' });

0 commit comments

Comments
 (0)