Skip to content

Commit ac5882a

Browse files
cli version upgrade to 1.30.9
1 parent 775dff8 commit ac5882a

File tree

3 files changed

+15
-26
lines changed

3 files changed

+15
-26
lines changed

README.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -228,13 +228,6 @@ public class Example {
228228
- `height` (number): Height of the region.
229229
- `elementXpath` (string): The XPath selector for the element.
230230
- `elementCSS` (string): The CSS selector for the element.
231-
- `padding` (optional)
232-
- Specifies additional padding around the selected region.
233-
- Properties:
234-
- `top` (number): Padding from the top.
235-
- `left` (number): Padding from the left.
236-
- `right` (number): Padding from the right.
237-
- `bottom` (number): Padding from the bottom.
238231
- `algorithm` (mandatory)
239232
- Specifies the snapshot comparison algorithm.
240233
- Allowed values: `standard`, `layout`, `ignore`, `intelliignore`.
@@ -252,12 +245,6 @@ public class Example {
252245
Map<String, Object> elementSelector = new HashMap<>();
253246
elementSelector.put("elementCSS", ".ad-banner");
254247

255-
Map<String, Object> padding = new HashMap<>();
256-
padding.put("top", 10);
257-
padding.put("left", 20);
258-
padding.put("right", 15);
259-
padding.put("bottom", 10);
260-
261248
Map<String, Object> configuration = new HashMap<>();
262249
configuration.put("diffSensitivity", 2);
263250
configuration.put("imageIgnoreThreshold", 0.2);
@@ -270,7 +257,6 @@ public class Example {
270257

271258
Map<String, Object> obj1 = new HashMap<>();
272259
obj1.put("elementSelector", elementSelector);
273-
obj1.put("padding", padding);
274260
obj1.put("algorithm", "intelliignore");
275261
obj1.put("configuration", configuration);
276262
obj1.put("assertion", assertion);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
"test": "npx percy exec --testing -- mvn test"
55
},
66
"devDependencies": {
7-
"@percy/cli": "1.28.0"
7+
"@percy/cli": "1.30.9"
88
}
99
}

src/main/java/io/percy/selenium/Percy.java

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,20 @@ public Percy(WebDriver driver) {
7777
/**
7878
* Creates a region configuration based on the provided parameters.
7979
*
80-
* @param boundingBox The bounding box of the region, or null.
81-
* @param elementXpath The XPath of the element, or null.
82-
* @param elementCSS The CSS selector of the element, or null.
83-
* @param padding The padding around the region, or null.
84-
* @param algorithm The algorithm to be used (default 'ignore').
85-
* @param diffSensitivity The sensitivity for diffing, or null.
86-
* @param imageIgnoreThreshold The image ignore threshold, or null.
87-
* @param carouselsEnabled Flag for enabling carousels, or null.
88-
* @param bannersEnabled Flag for enabling banners, or null.
89-
* @param adsEnabled Flag for enabling ads, or null.
90-
* @param diffIgnoreThreshold The diff ignore threshold, or null.
80+
* @param params A map containing the region configuration options. Expected keys:
81+
* <ul>
82+
* <li>boundingBox - The bounding box of the region, or null.</li>
83+
* <li>elementXpath - The XPath of the element, or null.</li>
84+
* <li>elementCSS - The CSS selector of the element, or null.</li>
85+
* <li>padding - The padding around the region, or null.</li>
86+
* <li>algorithm - The algorithm to be used (default: 'ignore').</li>
87+
* <li>diffSensitivity - The sensitivity for diffing, or null.</li>
88+
* <li>imageIgnoreThreshold - The image ignore threshold, or null.</li>
89+
* <li>carouselsEnabled - Flag for enabling carousels, or null.</li>
90+
* <li>bannersEnabled - Flag for enabling banners, or null.</li>
91+
* <li>adsEnabled - Flag for enabling ads, or null.</li>
92+
* <li>diffIgnoreThreshold - The diff ignore threshold, or null.</li>
93+
* </ul>
9194
* @return A map representing the region configuration.
9295
*/
9396

0 commit comments

Comments
 (0)