Skip to content

Commit e735ff8

Browse files
cli version upgrade to 1.30.9
1 parent 62ba70d commit e735ff8

File tree

3 files changed

+15
-26
lines changed

3 files changed

+15
-26
lines changed

README.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -230,13 +230,6 @@ public class Example {
230230
- `height` (number): Height of the region.
231231
- `elementXpath` (string): The XPath selector for the element.
232232
- `elementCSS` (string): The CSS selector for the element.
233-
- `padding` (optional)
234-
- Specifies additional padding around the selected region.
235-
- Properties:
236-
- `top` (number): Padding from the top.
237-
- `left` (number): Padding from the left.
238-
- `right` (number): Padding from the right.
239-
- `bottom` (number): Padding from the bottom.
240233
- `algorithm` (mandatory)
241234
- Specifies the snapshot comparison algorithm.
242235
- Allowed values: `standard`, `layout`, `ignore`, `intelliignore`.
@@ -254,12 +247,6 @@ public class Example {
254247
Map<String, Object> elementSelector = new HashMap<>();
255248
elementSelector.put("elementCSS", ".ad-banner");
256249

257-
Map<String, Object> padding = new HashMap<>();
258-
padding.put("top", 10);
259-
padding.put("left", 20);
260-
padding.put("right", 15);
261-
padding.put("bottom", 10);
262-
263250
Map<String, Object> configuration = new HashMap<>();
264251
configuration.put("diffSensitivity", 2);
265252
configuration.put("imageIgnoreThreshold", 0.2);
@@ -272,7 +259,6 @@ public class Example {
272259

273260
Map<String, Object> obj1 = new HashMap<>();
274261
obj1.put("elementSelector", elementSelector);
275-
obj1.put("padding", padding);
276262
obj1.put("algorithm", "intelliignore");
277263
obj1.put("configuration", configuration);
278264
obj1.put("assertion", assertion);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
"test": "npx percy exec --testing -- mvn test"
55
},
66
"devDependencies": {
7-
"@percy/cli": "1.29.5-beta.0"
7+
"@percy/cli": "1.30.9"
88
}
99
}

src/main/java/io/percy/selenium/Percy.java

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -81,17 +81,20 @@ public Percy(WebDriver driver) {
8181
/**
8282
* Creates a region configuration based on the provided parameters.
8383
*
84-
* @param boundingBox The bounding box of the region, or null.
85-
* @param elementXpath The XPath of the element, or null.
86-
* @param elementCSS The CSS selector of the element, or null.
87-
* @param padding The padding around the region, or null.
88-
* @param algorithm The algorithm to be used (default 'ignore').
89-
* @param diffSensitivity The sensitivity for diffing, or null.
90-
* @param imageIgnoreThreshold The image ignore threshold, or null.
91-
* @param carouselsEnabled Flag for enabling carousels, or null.
92-
* @param bannersEnabled Flag for enabling banners, or null.
93-
* @param adsEnabled Flag for enabling ads, or null.
94-
* @param diffIgnoreThreshold The diff ignore threshold, or null.
84+
* @param params A map containing the region configuration options. Expected keys:
85+
* <ul>
86+
* <li>boundingBox - The bounding box of the region, or null.</li>
87+
* <li>elementXpath - The XPath of the element, or null.</li>
88+
* <li>elementCSS - The CSS selector of the element, or null.</li>
89+
* <li>padding - The padding around the region, or null.</li>
90+
* <li>algorithm - The algorithm to be used (default: 'ignore').</li>
91+
* <li>diffSensitivity - The sensitivity for diffing, or null.</li>
92+
* <li>imageIgnoreThreshold - The image ignore threshold, or null.</li>
93+
* <li>carouselsEnabled - Flag for enabling carousels, or null.</li>
94+
* <li>bannersEnabled - Flag for enabling banners, or null.</li>
95+
* <li>adsEnabled - Flag for enabling ads, or null.</li>
96+
* <li>diffIgnoreThreshold - The diff ignore threshold, or null.</li>
97+
* </ul>
9598
* @return A map representing the region configuration.
9699
*/
97100

0 commit comments

Comments
 (0)