Update eslint-plugin-jest v29.12.1

- Enable the `jest/no-error-equal` rule as an error.
- Enable the `jest/no-unnecessary-assertion` rule as an error.
- Enable the `jest/no-unneeded-async-expect-function` rule as a warning.
- Enable the `jest/prefer-mock-return-shorthand` rule as a warning.
- Enable the `jest/prefer-to-have-been-called` rule as a warning.
- Enable the `jest/prefer-to-have-been-called-times` rule as a warning.
- Enable the `jest/valid-expect-with-promise` rule as an error.
- Enable the `jest/valid-mock-module-path` rule as an error.

Author: amikheychik

package-lock.json

@@ -41,7 +41,7 @@
         "eslint-plugin-array-func": "^5.1.0",
         "eslint-plugin-cypress": "^5.2.1",
         "eslint-plugin-import": "^2.32.0",
-        "eslint-plugin-jest": "^29.0.1",
+        "eslint-plugin-jest": "^29.12.1",
         "eslint-plugin-jest-dom": "^5.5.0",
         "eslint-plugin-jsdoc": "^54.1.1",
         "eslint-plugin-n": "^17.21.3",
@@ -84,7 +84,7 @@
         "eslint-plugin-array-func": "5.1.0",
         "eslint-plugin-cypress": "5.2.1",
         "eslint-plugin-import": "2.32.0",
-        "eslint-plugin-jest": "29.0.1",
+        "eslint-plugin-jest": "29.12.1",
         "eslint-plugin-jest-dom": "5.5.0",
         "eslint-plugin-jsdoc": "54.1.1",
         "eslint-plugin-n": "17.21.3",

package.json

@@ -149,6 +149,11 @@ Class → Method → Method Signature → Precondition ("When").
 |
 | Error
 
+| `link:{eslint-jest-rules}/no-unneeded-async-expect-function.md[jest/no-unneeded-async-expect-function]`
+|
+| Yes
+| Warning
+
 | `link:{eslint-jest-rules}/no-untyped-mock-factory.md[jest/no-untyped-mock-factory]`
 |
 | Yes
@@ -260,6 +265,11 @@ Class → Method → Method Signature → Precondition ("When").
 | Yes
 | Warning
 
+| `link:{eslint-jest-rules}/prefer-mock-return-shorthand.md[jest/prefer-mock-return-shorthand]`
+|
+| Yes
+| Warning
+
 | `link:{eslint-jest-rules}/prefer-snapshot-hint.md[jest/prefer-snapshot-hint]`
 |
 |
@@ -285,6 +295,16 @@ Class → Method → Method Signature → Precondition ("When").
 | Yes
 | Warning
 
+| `link:{eslint-jest-rules}/prefer-to-have-been-called.md[jest/prefer-to-have-been-called]`
+|
+| Yes
+| Warning
+
+| `link:{eslint-jest-rules}/prefer-to-have-been-called-times.md[jest/prefer-to-have-been-called-times]`
+|
+| Yes
+| Warning
+
 | `link:{eslint-jest-rules}/prefer-to-have-length.md[jest/prefer-to-have-length]`
 |
 | Yes
@@ -325,6 +345,11 @@ Class → Method → Method Signature → Precondition ("When").
 |
 | Error
 
+| `link:{eslint-jest-rules}/valid-mock-module-path.md[jest/valid-mock-module-path]`
+|
+|
+| Error
+
 | `link:{eslint-jest-rules}/valid-title.md[jest/valid-title]`
 | Yes
 | Yes
@@ -339,10 +364,25 @@ Class → Method → Method Signature → Precondition ("When").
 |===
 | Rule | Recommended | Fixable | Config
 
-| `link:{eslint-jest-rules}/unbound-method.md[jest/valid-title]`
+| `link:{eslint-jest-rules}/no-error-equal.md[jest/no-error-equal]`
+|
+|
+| Error
+
+| `link:{eslint-jest-rules}/no-unnecessary-assertion.md[jest/no-unnecessary-assertion]`
+|
+|
+| Error
+
+| `link:{eslint-jest-rules}/unbound-method.md[jest/unbound-method]`
 |
 |
 | Error
 4+| Extends the base `@typescript-eslint/unbound-method` rule to support `expect` calls.
 
+| `link:{eslint-jest-rules}/valid-expect-with-promise.md[jest/valid-expect-with-promise]`
+|
+|
+| Error
+
 |===

src/config/jest/index.adoc

@@ -64,6 +64,7 @@ export function jestConfig(files: Glob[] = jestFiles): Linter.Config {
             'jest/no-standalone-expect': 'error',
             'jest/no-test-prefixes': 'warn',
             'jest/no-test-return-statement': 'error',
+            'jest/no-unneeded-async-expect-function': 'warn',
             'jest/no-untyped-mock-factory': 'warn',
             'jest/padding-around-after-all-blocks': 'warn',
             'jest/padding-around-after-each-blocks': 'warn',
@@ -87,14 +88,18 @@ export function jestConfig(files: Glob[] = jestFiles): Linter.Config {
             'jest/prefer-lowercase-title': ['error', {
                 allowedPrefixes: [],
                 ignore: [],
+                ignoreTodos: false,
                 ignoreTopLevelDescribe: true,
             }],
             'jest/prefer-mock-promise-shorthand': 'warn',
+            'jest/prefer-mock-return-shorthand': 'warn',
             'jest/prefer-snapshot-hint': ['error', 'always'],
             'jest/prefer-spy-on': 'warn',
             'jest/prefer-strict-equal': 'warn',
             'jest/prefer-to-be': 'warn',
             'jest/prefer-to-contain': 'warn',
+            'jest/prefer-to-have-been-called': 'warn',
+            'jest/prefer-to-have-been-called-times': 'warn',
             'jest/prefer-to-have-length': 'warn',
             'jest/prefer-todo': 'warn',
             'jest/require-hook': ['error', {
@@ -105,6 +110,7 @@ export function jestConfig(files: Glob[] = jestFiles): Linter.Config {
             'jest/valid-describe-callback': 'error',
             'jest/valid-expect-in-promise': 'error',
             'jest/valid-expect': 'error',
+            'jest/valid-mock-module-path': 'error',
             'jest/valid-title': ['warn', {
                 ignoreTypeOfDescribeName: true,
                 ignoreTypeOfTestName: false,

src/config/jest/jest-config.ts

@@ -1,7 +1,10 @@
 import { Linter } from 'eslint';
 
 export const typescriptEslintJestRules: Linter.RulesRecord = {
+    'jest/no-error-equal': 'error',
+    'jest/no-unnecessary-assertion': 'error',
     'jest/unbound-method': ['error', {
         ignoreStatic: false,
     }],
+    'jest/valid-expect-with-promise': 'error',
 };