Skip to content

Commit d4d3918

Browse files
ci: create a new zip file to preserve permissions
Because the actions/upload-artifact@v2 workflow does not preserve permissions, see actions/upload-artifact#38
1 parent 38ed3a2 commit d4d3918

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,13 @@ jobs:
3030
- name: Build plugin
3131
run: make dist
3232

33+
- name: Create a zip file
34+
run: |
35+
mv dist performancecopilot-pcp-app
36+
zip -r performancecopilot-pcp-app.zip performancecopilot-pcp-app
37+
3338
- name: Publish build artifact
3439
uses: actions/upload-artifact@v2
3540
with:
36-
name: grafana-pcp
37-
path: dist
41+
name: build
42+
path: performancecopilot-pcp-app.zip

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
- **vector**: perform rate conversion only if it's enabled in the query options (it is by default)
1111
- **build**: add workaround to replace deprecated md4 hash algorithm with sha256 during build (md4 is unavailable in OpenSSL 3.0)
1212
- **build**: update Node.js and Go dependencies, and grafonnet
13+
- **build**: double-zip build artifacts in the CI workflow to preserve permissions (see [actions/upload-artifact#38](https://github.com/actions/upload-artifact/issues/38))
1314
- **docs**: add PCP Vector eBPF/BCC Overview dashboard screenshots
1415

1516

scripts/github-release.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ if [[ "${GRAFANA_PLUGIN_VERSION}" == *beta* ]]; then
1919
fi
2020

2121
mv dist "${GRAFANA_PLUGIN_ID}"
22-
zip "${GRAFANA_PLUGIN_ARTIFACT}" "${GRAFANA_PLUGIN_ID}" -r
22+
zip -r "${GRAFANA_PLUGIN_ARTIFACT}" "${GRAFANA_PLUGIN_ID}"
2323
md5sum "${GRAFANA_PLUGIN_ARTIFACT}" > "${GRAFANA_PLUGIN_ARTIFACT_CHECKSUM}"
2424
GRAFANA_PLUGIN_CHECKSUM=$(cut -d' ' -f1 "${GRAFANA_PLUGIN_ARTIFACT_CHECKSUM}")
2525

0 commit comments

Comments
 (0)