Work in review feedback

Author: Ongy

helm/extensions.bzl

@@ -2,6 +2,10 @@
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
+load(
+    "//helm:defs.bzl",
+    "helm_import_repository",
+)
 load(
     "//helm:repositories.bzl",
     "helm_host_alias_repository",
@@ -14,10 +18,6 @@ load(
     "DEFAULT_HELM_VERSION",
     "HELM_VERSIONS",
 )
-load(
-    "//helm:defs.bzl",
-    "helm_import_repository",
-)
 
 _HELM_TAR_BUILD_CONTENT = """\
 package(default_visibility = ["//visibility:public"])
@@ -43,6 +43,16 @@ def _helm_impl(ctx):
             _register_toolchains(version, helm_url_templates, plugins)
             _register_go_yaml()
 
+        for repository in module.tags.import_repository:
+            helm_import_repository(
+                name = repository.name,
+                chart_name = repository.chart_name,
+                repository = repository.repository,
+                sha256 = repository.sha256,
+                url = repository.url,
+                version = repository.version,
+            )
+
 def _register_toolchains(version, helm_url_templates, plugins):
     if not version in HELM_VERSIONS:
         fail("{} is not a supported version ({})".format(version, HELM_VERSIONS.keys()))
@@ -133,42 +143,26 @@ helm = module_extension(
     tag_classes = {
         "options": _toolchain,  # deprecated: use toolchain instead and remove in next major version
         "toolchain": _toolchain,
+        "import_repository": tag_class(attrs = {
+            "name": attr.string(
+                doc = "Name for the import dependency",
+            ),
+            "chart_name": attr.string(
+                doc = "Chart name to import.",
+            ),
+            "repository": attr.string(
+                doc = "Chart repository url where to locate the requested chart.",
+                mandatory = True,
+            ),
+            "sha256": attr.string(
+                doc = "The expected SHA-256 hash of the chart imported.",
+            ),
+            "url": attr.string(
+                doc = "The url where the chart can be directly downloaded.",
+            ),
+            "version": attr.string(
+                doc = "Specify a version constraint for the chart version to use.",
+            ),
+        }),
     },
 )
-
-def _helm_import_impl(module_ctx):
-    for mod in module_ctx.modules:
-        for repository in mod.tags.repository:
-            helm_import_repository(
-                name = repository.name,
-                chart_name = repository.chart_name,
-                repository = repository.repository,
-                sha256 = repository.sha256,
-                url = repository.url,
-                version = repository.version,
-            )
-
-helm_import = module_extension(
-    implementation = _helm_import_impl,
-    tag_classes = {"repository": tag_class(attrs = {
-        "name": attr.string(
-            doc = "Name for the import dependency",
-        ),
-        "chart_name": attr.string(
-            doc = "Chart name to import.",
-        ),
-        "repository": attr.string(
-            doc = "Chart repository url where to locate the requested chart.",
-            mandatory = True,
-        ),
-        "sha256": attr.string(
-            doc = "The expected SHA-256 hash of the chart imported.",
-        ),
-        "url": attr.string(
-            doc = "The url where the chart can be directly downloaded.",
-        ),
-        "version": attr.string(
-            doc = "Specify a version constraint for the chart version to use.",
-        ),
-    })},
-)