Fix handling of Xcode projects with quotes in their path and scheme names. Closes #730

Author: ileitch

CHANGELOG.md

@@ -11,6 +11,7 @@
 ##### Bug Fixes
 
 - Unused parameter warnings are suppressed in `@available(*, unavailable)` functions.
+- Fix handling of Xcode projects with single and double quotes in their path and scheme names.
 
 ## 3.0.3 (2025-03-15)
 

Sources/Extensions/String+Extension.swift

@@ -32,4 +32,8 @@ public extension String {
     @inlinable var djb2Hex: String {
         String(format: "%02x", djb2)
     }
+
+    @inlinable var withEscapedQuotes: String {
+        replacingOccurrences(of: "\"", with: "\\\"")
+    }
 }

Sources/XcodeSupport/XcodeProjectSetupGuide.swift

@@ -117,10 +117,10 @@ public final class XcodeProjectSetupGuide: SetupGuideHelpers, SetupGuide {
         var options: [String] = []
 
         if let project = configuration.project {
-            options.append("--project \"\(project)\"")
+            options.append("--project \"\(project.string.withEscapedQuotes)\"")
         }
 
-        options.append("--schemes " + configuration.schemes.map { "\"\($0)\"" }.joined(separator: ","))
+        options.append("--schemes " + configuration.schemes.map { "\"\($0.withEscapedQuotes)\"" }.joined(separator: ","))
 
         if configuration.retainObjcAccessible {
             options.append("--retain-objc-accessible")

Sources/XcodeSupport/Xcodebuild.swift

@@ -35,8 +35,8 @@ public final class Xcodebuild {
     @discardableResult
     public func build(project: XcodeProjectlike, scheme: String, allSchemes: [String], additionalArguments: [String] = []) throws -> String {
         let args = try [
-            "-\(project.type)", "'\(project.path.lexicallyNormalized().string)'",
-            "-scheme", "'\(scheme)'",
+            "-\(project.type)", "\"\(project.path.lexicallyNormalized().string.withEscapedQuotes)\"",
+            "-scheme", "\"\(scheme.withEscapedQuotes)\"",
             "-parallelizeTargets",
             "-derivedDataPath", "'\(derivedDataPath(for: project, schemes: allSchemes).string)'",
             "-quiet",
@@ -79,7 +79,7 @@ public final class Xcodebuild {
 
     func schemes(type: String, path: String, additionalArguments: [String]) throws -> Set<String> {
         let args = [
-            "-\(type)", "'\(path)'",
+            "-\(type)", "\"\(path.withEscapedQuotes)\"",
             "-list",
             "-json",
         ]

baselines/linux.json

@@ -1 +1 @@
-{"v1":{"usrs":["import-Configuration-Sources\/ProjectDrivers\/XcodeProjectDriver.swift:2:5","import-Indexer-Sources\/ProjectDrivers\/XcodeProjectDriver.swift:4:5","import-Logger-Sources\/ProjectDrivers\/XcodeProjectDriver.swift:5:5","import-Shared-Sources\/ProjectDrivers\/XcodeProjectDriver.swift:6:5","import-SourceGraph-Sources\/ProjectDrivers\/XcodeProjectDriver.swift:7:5","import-TestShared-Tests\/PeripheryTests\/ObjcAccessibleRetentionTest.swift:2:1","import-TestShared-Tests\/PeripheryTests\/ObjcAnnotatedRetentionTest.swift:2:1","s:11SourceGraph15ProjectFileKindO10extensionsSaySSGvp","s:6Shared14SetupSelectionO","s:6Shared17SetupGuideHelpersC6select8multipleAA0B9SelectionOSaySSG_tF","s:SS10ExtensionsE4djb2Sivp","s:SS10ExtensionsE7djb2HexSSvp"]}}
+{"v1":{"usrs":["import-Configuration-Sources\/ProjectDrivers\/XcodeProjectDriver.swift:2:5","import-Indexer-Sources\/ProjectDrivers\/XcodeProjectDriver.swift:4:5","import-Logger-Sources\/ProjectDrivers\/XcodeProjectDriver.swift:5:5","import-Shared-Sources\/ProjectDrivers\/XcodeProjectDriver.swift:6:5","import-SourceGraph-Sources\/ProjectDrivers\/XcodeProjectDriver.swift:7:5","import-TestShared-Tests\/PeripheryTests\/ObjcAccessibleRetentionTest.swift:2:1","import-TestShared-Tests\/PeripheryTests\/ObjcAnnotatedRetentionTest.swift:2:1","s:11SourceGraph15ProjectFileKindO10extensionsSaySSGvp","s:6Shared14SetupSelectionO","s:6Shared17SetupGuideHelpersC6select8multipleAA0B9SelectionOSaySSG_tF","s:SS10ExtensionsE17withEscapedQuotesSSvp","s:SS10ExtensionsE4djb2Sivp","s:SS10ExtensionsE7djb2HexSSvp"]}}