Fix unstable parameter USR

Author: ileitch

CHANGELOG.md

@@ -14,6 +14,7 @@
 - Fix unused import false-positives where the only referenced declaration is generated by a macro.
 - Fix building with Bazel on Linux by excluding Xcode support.
 - Fix slow baseline filtering for large projects with many results.
+- Fix inconsistent unused parameter results when the function is declared in a file that is a member of multiple targets.
 
 ## 3.1.0 (2025-04-05)
 

Sources/PeripheryKit/Results/CodeClimateFormatter.swift

@@ -28,14 +28,14 @@ final class CodeClimateFormatter: OutputFormatter {
                 .joined(separator: ", ")
 
             let fingerprint: String = if result.declaration.kind == .varParameter,
-                                         let parentFingerprint = result.declaration.parent?.usrs.joined(separator: "."),
+                                         let parentFingerprint = result.declaration.parent?.usrs.sorted().joined(separator: "."),
                                          let argumentName = result.declaration.name
             {
                 // As function parameters do not have a mangled name that can be used for the fingerprint
                 // we take the mangled name of the function and append the position
                 "\(parentFingerprint)-\(argumentName)"
             } else {
-                result.declaration.usrs.joined(separator: ".")
+                result.declaration.usrs.sorted().joined(separator: ".")
             }
 
             let object: [AnyHashable: Any] = [

Sources/PeripheryKit/Results/CsvFormatter.swift

@@ -62,9 +62,9 @@ final class CsvFormatter: OutputFormatter {
         location: Location,
         hint: String?
     ) -> String {
-        let joinedModifiers = attributes.joined(separator: "|")
-        let joinedAttributes = modifiers.joined(separator: "|")
-        let joinedUsrs = usrs.joined(separator: "|")
+        let joinedModifiers = attributes.sorted().joined(separator: "|")
+        let joinedAttributes = modifiers.sorted().joined(separator: "|")
+        let joinedUsrs = usrs.sorted().joined(separator: "|")
         let path = locationDescription(location)
         return "\(kind),\(name ?? ""),\(joinedModifiers),\(joinedAttributes),\(accessibility ?? ""),\(joinedUsrs),\(path),\(hint ?? "")"
     }

Sources/PeripheryKit/Results/JsonFormatter.swift

@@ -16,12 +16,12 @@ final class JsonFormatter: OutputFormatter {
         for result in results {
             let object: [AnyHashable: Any] = [
                 "kind": result.declaration.kind.rawValue,
-                "modules": Array(result.declaration.location.file.modules),
+                "modules": result.declaration.location.file.modules.sorted(),
                 "name": result.declaration.name ?? "",
-                "modifiers": Array(result.declaration.modifiers),
-                "attributes": Array(result.declaration.attributes),
+                "modifiers": result.declaration.modifiers.sorted(),
+                "attributes": result.declaration.attributes.sorted(),
                 "accessibility": result.declaration.accessibility.value.rawValue,
-                "ids": Array(result.declaration.usrs),
+                "ids": result.declaration.usrs.sorted(),
                 "hints": [describe(result.annotation)],
                 "location": locationDescription(result.declaration.location),
             ]

Sources/SyntaxAnalysis/UnusedParameterParser.swift

@@ -51,7 +51,7 @@ public struct Parameter: Item, Hashable {
     }
 
     public func makeDeclaration(withParent parent: Declaration) -> Declaration {
-        let parentUsrs = parent.usrs.joined(separator: "-")
+        let parentUsrs = parent.usrs.sorted().joined(separator: "-")
         let usr = "param-\(name)-\(parent.name ?? "unknown-function")-\(parentUsrs)"
         let decl = Declaration(kind: .varParameter, usrs: [usr], location: location)
         decl.name = name