Skip to content

Commit c0400fe

Browse files
committed
Don't assume that LoginName or NodeName is at least 2 characters long
1 parent 6cba957 commit c0400fe

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Changes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ Revision history for the Perl extension Win32.
44
- Make sure %PROCESSOR_ARCHITECTURE% is defined before calling
55
Win32::GetArchName() in t/Names.t. It may be undefined when
66
the test is running under Cygwin crond.
7+
- In t/Names.t don't assume that LoginName or NodeName is at
8+
least 2 characters long; it may just be 1.
79

810
0.46 [2013-02-19]
911
- add Win2012/Win8 detection (thanks to Michiel Beijen) [rt#82572]

t/Names.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ is( $osname2, $osname, " - checking that OS name is the same in both calls" );
4949
# test Win32::LoginName()
5050
my $login = eval { Win32::LoginName() };
5151
is( $@, '', "Win32::LoginName()" );
52-
cmp_ok( length($login), '>', 1, " - checking returned login name" );
52+
cmp_ok( length($login), '>', 0, " - checking returned login name" );
5353

5454
# test Win32::NodeName()
5555
my $nodename = eval { Win32::NodeName() };
5656
is( $@, '', "Win32::NodeName()" );
57-
cmp_ok( length($nodename), '>', 1, " - checking returned node name" );
57+
cmp_ok( length($nodename), '>', 0, " - checking returned node name" );

0 commit comments

Comments
 (0)