Remove wrong usage of $sth->finish() from all tests

According to DBI documentation $sth->finish() should not be called after
fetching all data.

Author: pali

t/30insertfetch.t

@@ -40,8 +40,6 @@ ok($sth->execute());
 
 ok(not $sth->fetchrow_arrayref());
 
-ok($sth->finish());
-
 ok($dbh->disconnect());
 
 done_testing;

t/31insertid.t

@@ -11,7 +11,7 @@ require "lib.pl";
 my $dbh = DbiTestConnect($test_dsn, $test_user, $test_password,
                          { RaiseError => 1, PrintError => 0 });
 
-plan tests => 3 + 2*37;
+plan tests => 3 + 2*35;
 
 SKIP: {
     skip 'SET @@auto_increment_offset needs MySQL >= 5.0.2', 2 unless $dbh->{mariadb_serverversion} >= 50002;
@@ -87,9 +87,6 @@ is $sth->last_insert_id(), 2, "second insert id == \$sth->last_insert_id()";
 is $sth3->{mariadb_insertid}, 3, "third insert id == \$sth3->{mariadb_insertid}";
 is $sth3->last_insert_id(), 3, "third insert id == \$sth3->last_insert_id()";
 
-ok $sth->finish();
-ok $sth2->finish();
-
 ok $dbh->do('DROP TEMPORARY TABLE dbd_mysql_t31');
 
 }

t/32insert_error.t

@@ -11,7 +11,7 @@ use vars qw($test_dsn $test_user $test_password);
 my $dbh = DbiTestConnect($test_dsn, $test_user, $test_password,
   { RaiseError => 1, PrintError => 0 });
 
-plan tests => 9;
+plan tests => 8;
 
 ok $dbh->do("DROP TABLE IF EXISTS dbd_mysql_t32");
 
@@ -33,8 +33,6 @@ ok $failed, 'fails with duplicate entry';
 
 ok $sth->execute(2, "Jochen");
 
-ok $sth->finish;
-
 ok $dbh->do("DROP TABLE dbd_mysql_t32");
 
 ok $dbh->disconnect();

t/35limit.t

@@ -14,7 +14,7 @@ require 'lib.pl';
 
 my $dbh = DbiTestConnect($test_dsn, $test_user, $test_password,
                       { RaiseError => 1, PrintError => 0, AutoCommit => 0 });
-plan tests => 111;
+plan tests => 110;
 
 ok(defined $dbh, "Connected to database");
 
@@ -44,8 +44,6 @@ ok( (defined($array_ref = $sth->fetchall_arrayref) &&
 
 ok(@$array_ref == 50);
 
-ok($sth->finish);
-
 ok($dbh->do("DROP TABLE dbd_mysql_t35"));
 
 ok($dbh->disconnect);

t/35prepare.t

@@ -13,7 +13,7 @@ use vars qw($test_dsn $test_user $test_password);
 $dbh = DbiTestConnect($test_dsn, $test_user, $test_password,
     { RaiseError => 1, PrintError => 0 });
 
-plan tests => 49;
+plan tests => 47;
 
 ok(defined $dbh, "Connected to database");
 
@@ -45,8 +45,6 @@ ok(($rows = $sth->execute()), "Inserting second row");
 
 ok($rows == 1, "One row should have been inserted");
 
-ok($sth->finish, "Finishing up with statement handle");
-
 ok($sth= $dbh->prepare("SELECT id, name FROM dbd_mysql_t35prepare WHERE id = 1"),
   "Testing prepare of query");
 
@@ -69,8 +67,6 @@ for (my $i = 0 ; $i < 10; $i++)
   ok($rows= 1, "Should have inserted one row");
 }
 
-ok($sth->finish, "Testing closing of statement handle");
-
 ok($sth= $dbh->prepare("SELECT * FROM dbd_mysql_t35prepare WHERE id = ? OR id = ?"),
   "Testing prepare of query with placeholders");
 

t/40bindparam.t

@@ -10,7 +10,7 @@ use vars qw($test_dsn $test_user $test_password);
 my $dbh = DbiTestConnect($test_dsn, $test_user, $test_password,
                       { RaiseError => 1, PrintError => 0 });
 
-plan tests => 41;
+plan tests => 40;
 
 ok ($dbh->do("DROP TABLE IF EXISTS dbd_mysql_t40bindparam"));
 
@@ -109,6 +109,4 @@ cmp_ok $name, 'eq', '?', "\$name set to '?'";
 
 ok ($dbh->do("DROP TABLE dbd_mysql_t40bindparam"));
 
-ok $sth->finish;
-
 ok $dbh->disconnect;

t/40bindparam2.t

@@ -10,7 +10,7 @@ require 'lib.pl';
 my $dbh = DbiTestConnect($test_dsn, $test_user, $test_password,
   { RaiseError => 1, PrintError => 0 });
 
-plan tests => 14;
+plan tests => 13;
 
 SKIP: {
     skip 'SET @@auto_increment_offset needs MySQL >= 5.0.2', 2 unless $dbh->{mariadb_serverversion} >= 50002;
@@ -41,8 +41,6 @@ ok ($sth->bind_param(2, 1, DBI::SQL_INTEGER()));
 
 ok ($sth->execute());
 
-ok ($sth->finish());
-
 ok ($rows = $dbh->selectall_arrayref("SELECT * FROM dbd_mysql_t40bindparam2"));
 
 ok !defined($rows->[0][1]);

t/40bit.t

@@ -14,7 +14,7 @@ if ($dbh->{mariadb_serverversion} < 50008) {
     plan skip_all => "Servers < 5.0.8 do not support b'' syntax";
 }
 
-plan tests => 15;
+plan tests => 14;
 
 ok $dbh->do("DROP TABLE IF EXISTS dbd_mysql_b1"), "Drop table if exists dbd_mysql_b1";
 
@@ -36,8 +36,6 @@ is $result->[0][0], 11111111, "should be 11111111";
 is $result->[1][0], 1010, "should be 1010";
 is $result->[2][0], 101, "should be 101";
 
-ok ($sth->finish);
-
 ok $dbh->do("DROP TABLE dbd_mysql_b1"), "Drop table dbd_mysql_b1";
 
 ok $dbh->disconnect;

t/40blobs.t

@@ -24,7 +24,7 @@ sub ShowBlob($) {
 my $dbh = DbiTestConnect($test_dsn, $test_user, $test_password,
   { RaiseError => 1, PrintError => 0 });
 
-plan tests => 14;
+plan tests => 13;
 
 my $size= 128;
 
@@ -70,8 +70,6 @@ cmp_ok byte_string($$row[1]), 'eq', byte_string($blob), 'blob set equal to blob
 
 ShowBlob($blob), ShowBlob(defined($$row[1]) ? $$row[1] : "");
 
-ok ($sth->finish);
-
 ok $dbh->do("DROP TABLE dbd_mysql_t40blobs"), "Drop table dbd_mysql_t40blobs";
 
 ok $dbh->disconnect;

t/40nulls.t

@@ -10,7 +10,7 @@ require 'lib.pl';
 my ($dbh, $sth);
 $dbh = DbiTestConnect($test_dsn, $test_user, $test_password,
                       { RaiseError => 1, PrintError => 0, AutoCommit => 0 });
-plan tests => 10;
+plan tests => 9;
 
 ok $dbh->do("DROP TABLE IF EXISTS dbd_mysql_t40nulls"), "DROP TABLE IF EXISTS dbd_mysql_t40nulls";
 
@@ -34,8 +34,6 @@ ok !defined($$aref[0]);
 
 ok defined($$aref[1]);
 
-ok $sth->finish;
-
 ok $dbh->do("DROP TABLE dbd_mysql_t40nulls");
 
 ok $dbh->disconnect;