Disable usage of libmysqld.a from MySQL 8.x series

pali · pali · commit da0b2dcfe1f7 · 2019-08-29T10:59:16.000+02:00
It is broken and test t/12embedded.t is failing.
diff --git a/Makefile.PL b/Makefile.PL
@@ -743,6 +743,8 @@ sub Configure {
                     # and always crash in mysql_real_connect() function, so avoid its usage
                     # https://jira.mariadb.org/browse/MDEV-16478
                     $function .= "\n#if defined(MARIADB_BASE_VERSION) || defined(MARIADB_PACKAGE_VERSION)\nif (mysql_get_client_version() >= 100301 && mysql_get_client_version() < 100308) return 1;\n#endif\n";
+                    # libmysqld.a from MySQL 8.x is broken too
+                    $function .= "\n#if !defined(MARIADB_BASE_VERSION) && !defined(MARIADB_PACKAGE_VERSION)\nif (mysql_get_client_version() >= 80000) return 1;\n#endif\n";
                 }
                 $function .= 'return (mysql_get_client_version() == MYSQL_VERSION_ID) ? 0 : 1;';
                 # libmysqld is built using g++ rather than gcc and sometimes

Original file line number	Diff line number	Diff line change
`@@ -743,6 +743,8 @@ sub Configure {`
`743`	`743`	`# and always crash in mysql_real_connect() function, so avoid its usage`
`744`	`744`	`# https://jira.mariadb.org/browse/MDEV-16478`
`745`	`745`	`$function .= "\n#if defined(MARIADB_BASE_VERSION) \|\| defined(MARIADB_PACKAGE_VERSION)\nif (mysql_get_client_version() >= 100301 && mysql_get_client_version() < 100308) return 1;\n#endif\n";`
	`746`	`+ # libmysqld.a from MySQL 8.x is broken too`
	`747`	`+ $function .= "\n#if !defined(MARIADB_BASE_VERSION) && !defined(MARIADB_PACKAGE_VERSION)\nif (mysql_get_client_version() >= 80000) return 1;\n#endif\n";`
`746`	`748`	`}`
`747`	`749`	`$function .= 'return (mysql_get_client_version() == MYSQL_VERSION_ID) ? 0 : 1;';`
`748`	`750`	`# libmysqld is built using g++ rather than gcc and sometimes`