Skip to content

Commit b47f194

Browse files
committed
Update test for have_ssl removal
From https://dev.mysql.com/doc/relnotes/mysql/8.4/en/news-8-4-0.html "The --ssl and --admin-ssl server options, as well as the have_ssl and have_openssl server system variables, were all deprecated in MySQL 8.0.26, and are all removed in this release. Use --tls-version and --admin-tls-version instead." So testing for `have_ssl` no longer works as expected. Also removal of `--ssl`/`--skip-ssl` makes testing this more difficult.
1 parent 014f2c7 commit b47f194

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

t/92ssl_backronym_vulnerability.t

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ my $have_ssl = eval { $dbh->selectrow_hashref("SHOW VARIABLES WHERE Variable_nam
1313
$dbh->disconnect();
1414
plan skip_all => 'Server supports SSL connections, cannot test false-positive enforcement' if $have_ssl and $have_ssl->{Value} eq 'YES';
1515

16+
# `have_ssl` has been deprecated in 8.0.26 and removed in 8.4.0...
17+
plan skip_all => 'Server might support SSL connections, cannot test false-positive enforcement' if not $have_ssl;
18+
1619
plan tests => 4;
1720

1821
$dbh = DBI->connect($test_dsn, $test_user, $test_password, { PrintError => 0, RaiseError => 0, mysql_ssl => 1 });

t/92ssl_optional.t

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ my $have_ssl = eval { $dbh->selectrow_hashref("SHOW VARIABLES WHERE Variable_nam
1313
$dbh->disconnect();
1414
plan skip_all => 'Server supports SSL connections, cannot test fallback to plain text' if $have_ssl and $have_ssl->{Value} eq 'YES';
1515

16+
# `have_ssl` has been deprecated in 8.0.26 and removed in 8.4.0...
17+
plan skip_all => 'Server might support SSL connections, cannot test false-positive enforcement' if not $have_ssl;
18+
1619
plan tests => 2;
1720

1821
$dbh = DBI->connect($test_dsn, $test_user, $test_password, { PrintError => 1, RaiseError => 0, mysql_ssl => 1, mysql_ssl_optional => 1 });

t/92ssl_riddle_vulnerability.t

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ my $have_ssl = eval { $dbh->selectrow_hashref("SHOW VARIABLES WHERE Variable_nam
1313
$dbh->disconnect();
1414
plan skip_all => 'Server supports SSL connections, cannot test false-positive enforcement' if $have_ssl and $have_ssl->{Value} eq 'YES';
1515

16+
# `have_ssl` has been deprecated in 8.0.26 and removed in 8.4.0...
17+
plan skip_all => 'Server might support SSL connections, cannot test false-positive enforcement' if not $have_ssl;
18+
1619
plan tests => 4;
1720

1821
$dbh = DBI->connect($test_dsn, '4yZ73s9qeECdWi', '64heUGwAsVoNqo', { PrintError => 0, RaiseError => 0, mysql_ssl => 1 });

0 commit comments

Comments
 (0)