Fails with MariaDB, and my assumption was that the 4.* branch should keep compatibility with MariaDB?

[dveeden]

Fails with MariaDB, and my assumption was that the 4.* branch should keep compatibility with MariaDB?

dbdimp.c: In function 'parse_params':
dbdimp.c:769:22: error: implicit declaration of function 'mysql_real_escape_string_quote'; did you mean 'mysql_real_escape_string'? [-Wimplicit-function-declaration]
  769 |               ptr += mysql_real_escape_string_quote(sock, ptr, valbuf, vallen, '\'');
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                      mysql_real_escape_string
make[1]: *** [Makefile:358: dbdimp.o] Error 1

Originally posted by @gregoa in #458 (comment)

[dveeden]

Tested with this:

podman run --rm -v /path/to/DBD-mysql:/DBD-mysql:Z --network=host -it fedora:42

dnf install -y perl perl-DBI 'perl(Test::More)' 'perl(Devel::CheckLib)' 'perl(Test::Deep)' mariadb-devel git
cd /DBD-mysql
perl Makefile.PL --testhost 127.0.0.1 --testuser root
make
make test

I first got the same error as reported and then modified the code to compile.

Note that I have a MySQL 9.2.0 instance on port 3306, made available by --network=host.

# mysql_clientversion is: 30403
# mysql_serverversion is: 90200
# mysql_hostinfo is: 127.0.0.1 via TCP/IP
# mysql_serverinfo is: 9.2.0
# mysql_stat is: Uptime: 941364  Threads: 49  Questions: 1532638  Slow queries: 8  Opens: 983  Flush tables: 5  Open tables: 499  Queries per second avg: 1.628
# mysql_protoinfo is: 10
# SQL_DBMS_VER is 9.2.0
# Default storage engine is: InnoDB

I got one unrelated failure

t/92ssl_optional.t ...................... 1/2 DBI connect('test:127.0.0.1','root',...) failed: TLS/SSL error: No such file or directory (2) at t/92ssl_optional.t line 21.

#   Failed test 'DBD::mysql supports mysql_ssl_optional=1 and connect via plain text protocol when SSL is not supported by server even with mysql_ssl_ca_file'
#   at t/92ssl_optional.t line 22.
# Error code: 2026
# Error message: TLS/SSL error: No such file or directory (2)
# Looks like you failed 1 test of 2.
t/92ssl_optional.t ...................... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests 

[dveeden]

@gregoa could you give this a try?

[gregoa]

Works!
Thank you.

[dkechag]

Sorry, do we expect this to be included in a new v4 release? I had arrived to a similar patch for my own purposes, and then I saw it was already done here, but it didn't make 4.053.