From b9d4976350124572fae0ccd397d84df8ddc34999 Mon Sep 17 00:00:00 2001 From: Dave Lambley Date: Thu, 24 Oct 2024 14:56:11 +0100 Subject: [PATCH 1/3] Correct email address --- Makefile.PL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index bbca1a8a..be4000bf 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -250,7 +250,7 @@ if (eval $ExtUtils::MakeMaker::VERSION >= 5.43) { 'Damyan Ivanov ', 'Dan Book ', 'Daniƫl van Eeden ', - 'Dave Lambley ', + 'Dave Lambley ', 'David Farrell ', 'David Steinbrunner ', 'Giovanni Bechis ', From e54914a547219b46d06bf3f5b42bb37152941e02 Mon Sep 17 00:00:00 2001 From: Dave Lambley Date: Thu, 24 Oct 2024 17:10:48 +0100 Subject: [PATCH 2/3] Carefully compare library version numbers --- Makefile.PL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index be4000bf..5a763d7d 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -447,7 +447,7 @@ sub Configure { } if ($param eq 'version') { - if ($str !~ /^[89]\./) { + if ((split(/\./, $str, 2))[0] < 8) { die "DBD::mysql requires MySQL 8.x or newer for building. Version reported by $command: $str"; } } From c38d218bbf1654d24ef2beee21a04640bb9078ee Mon Sep 17 00:00:00 2001 From: Dave Lambley Date: Thu, 24 Oct 2024 17:11:22 +0100 Subject: [PATCH 3/3] Warn that MariaDB's client library does not work Debian no longer supplies libmysqlclient. It provides symlinks from mysql_config to mariadb_config. Unfortunately this gives us an unhelpful compilation error because we are using MySQL exclusive features. --- Makefile.PL | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index 5a763d7d..fb5fa3da 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -150,7 +150,18 @@ assert_lib( LIBS => $opt->{libs}, ); -print "Looks good.\n\n"; +if ($opt->{libs} =~ /mariadb/) { + print <<"MSG"; + +The chosen MySQL client library appears to be MariaDB's. Compilation may fail. +Consider DBD::MariaDB or installing Oracle's MySQL client library. + + +MSG +} +else { + print "Looks good.\n\n"; +} sleep 1;