Skip to content

Commit 00f8dd1

Browse files
committed
Merge pull request #16 from ilmari/blead-fix-defsv-not-lvalue
Use DEFSV_set() instead of assigning to DEFSV
2 parents 6f25fd0 + 7d32b92 commit 00f8dd1

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Changes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ DBI::Changes - List of significant changes to the DBI
1313
Changed t/42prof_data.t more informative
1414
Changed $sth->{TYPE} to be NUMERIC in DBD::File drivers as per the
1515
DBI docs. Note TYPE_NAME is now also available. [H.Merijn Brand]
16+
Fixed compilation error on bleadperl due GVSV no longer being an lvalue
17+
[Dagfinn Ilmari Manns�ker]
1618

1719
Added multi_ prefix for DBD::Multi (Dan Wright) and ad2_ prefix for
1820
DBD::AnyData2

DBI.xs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2900,7 +2900,7 @@ dbi_profile(SV *h, imp_xxh_t *imp_xxh, SV *statement_sv, SV *method, NV t1, NV t
29002900
PUSHs( sv_2mortal(newSVpv(method_pv,0)));
29012901
PUTBACK;
29022902
SAVE_DEFSV; /* local($_) = $statement */
2903-
DEFSV = statement_sv;
2903+
DEFSV_set(statement_sv);
29042904
items = call_sv(code_sv, G_ARRAY);
29052905
SPAGAIN;
29062906
SP -= items ;
@@ -3554,7 +3554,7 @@ XS(XS_DBI_dispatch)
35543554
*/
35553555
orig_defsv = DEFSV; /* remember the current $_ */
35563556
SAVE_DEFSV; /* local($_) = $method_name */
3557-
DEFSV = sv_2mortal(newSVpv(meth_name,0));
3557+
DEFSV_set(sv_2mortal(newSVpv(meth_name,0)));
35583558

35593559
EXTEND(SP, items+1);
35603560
PUSHMARK(SP);
@@ -3571,7 +3571,7 @@ XS(XS_DBI_dispatch)
35713571
/* put $_ back now, but with an incremented ref count to compensate
35723572
* for the ref count decrement that will happen when we exit the scope.
35733573
*/
3574-
DEFSV = SvREFCNT_inc(orig_defsv);
3574+
DEFSV_set(SvREFCNT_inc(orig_defsv));
35753575

35763576
if (trace_level)
35773577
PerlIO_printf(DBILOGFP, "%c }} %s callback %s returned%s\n",

0 commit comments

Comments
 (0)