-Wbad-function-cast caused weird and unreliable output on gcc-14 + 5.40.1

Mauke and me decided it better be removed

Author: Tux

ChangeLog

@@ -1,6 +1,7 @@
-1.648 - 2025-03-11, H.Merijn Brand
+1.648 - 2025-03-14, H.Merijn Brand
     * Correct sprintf usage for trace_msg (issue#132)
     * Add DBIXS_VERSION & DBIXS_RELEASE to dbixs_rev.h
+    * Remove -Wbad-function-cast
 
 1.647 - 2025-01-20, H.Merijn Brand
     * Spellcheck

Makefile.PL

@@ -106,7 +106,7 @@ if (my $gccversion = $Config{gccversion}) {	# ask gcc to be more pedantic
     if ($gccversion =~ m/ clang ([0-9][-0-9.]*)/i) {
 	print "Your perl was compiled with Clang (version $1). As this is not GCC, version checking is skipped.\n";
 	# https://clang.llvm.org/docs/DiagnosticsReference.html
-	$opts{DEFINE} .= " -W -Wall -Wpointer-arith -Wbad-function-cast";
+	$opts{DEFINE} .= " -W -Wall -Wpointer-arith";
 	$opts{DEFINE} .= " -Wno-comment -Wno-sign-compare -Wno-cast-qual";
 	$opts{DEFINE} .= " -Wmissing-noreturn -Wno-unused-parameter";
 	$opts{DEFINE} .= " -Wno-compound-token-split-by-macro -Wno-constant-conversion";
@@ -120,7 +120,7 @@ if (my $gccversion = $Config{gccversion}) {	# ask gcc to be more pedantic
 	    if $gccversion =~ m/^\D*(1|2\.[1-8])\b/;
 	print "Your perl was compiled with gcc (version $Config{gccversion}), okay.\n";
 	$gccversion =~ s/[^\d\.]//g; # just a number please
-	$opts{DEFINE} .= " -W -Wall -Wpointer-arith -Wbad-function-cast";
+	$opts{DEFINE} .= " -W -Wall -Wpointer-arith";
 	$opts{DEFINE} .= " -Wno-comment -Wno-sign-compare -Wno-cast-qual";
 	$opts{DEFINE} .= " -Wmissing-noreturn -Wno-unused-parameter" if $gccversion ge "3.0";
 	if ($is_developer && $::opt_g) {

lib/DBI/Changes.pm

@@ -12,7 +12,7 @@ DBI::Changes - List of significant changes to the DBI
 
 =encoding UTF-8
 
-=head2 Changes in DBI 1.648 - 11 Mar 2025
+=head2 Changes in DBI 1.648 - 14 Mar 2025
 
 =over 2
 
@@ -24,6 +24,10 @@ Correct sprintf usage for trace_msg (issue#132)
 
 Add DBIXS_VERSION & DBIXS_RELEASE to dbixs_rev.h
 
+=item *
+
+Remove -Wbad-function-cast
+
 =back
 
 =head2 Changes in DBI 1.647 - 20 Jan 2025