add jobs resolver tests

Author: patinthehat

tests/fixtures/item/27414470.json

@@ -0,0 +1,9 @@
+{
+    "by": "yiggydyang",
+    "id": 27414470,
+    "score": 1,
+    "time": 1622998836,
+    "title": "PocketSuite Is hiring Lead Engineers, Product Designers to enrich small business",
+    "type": "job",
+    "url": "https://www.ycombinator.com/companies/pocketsuite"
+}

tests/fixtures/item/27421523.json

@@ -0,0 +1,9 @@
+{
+    "by": "ifc",
+    "id": 27421523,
+    "score": 1,
+    "time": 1623067272,
+    "title": "Qventus (YC W15) Is Hiring Data Platform Engineers",
+    "type": "job",
+    "url": "https://jobs.lever.co/qventus/c0d604cf-ec1c-48ea-847d-5ffc7a67698d"
+}

tests/fixtures/jobstories.json

@@ -0,0 +1 @@
+[27421523, 27414470]

tests/lib/cache/RedisCache.test.ts

@@ -14,28 +14,34 @@ afterEach(() => {
 });
 
 it('adds items to the cache', async () => {
-    expect(await cache.has('one')).toBeFalsy();
+    const key = 'one-' + (Math.random() * 10000).toString();
 
-    cache.put('one', 1, 10);
+    expect(await cache.has(key)).toBeFalsy();
 
-    expect(await cache.get('one')).toBe(1);
+    cache.put(key, 1, 10);
+
+    expect(await cache.get(key)).toBe(1);
 });
 
 it('returns an item in the cache', async () => {
-    cache.put('one', 1, 10);
+    const key = 'one-' + (Math.random() * 10000).toString();
+
+    cache.put(key, 1, 10);
 
-    expect(await cache.get('one')).toStrictEqual(1);
+    expect(await cache.get(key)).toStrictEqual(1);
 });
 
 it('returns null for an item not in the cache', async () => {
     expect(await cache.get('missing')).toBeNull();
 });
 
 it('determines if an item is in the cache', async () => {
-    cache.put('one', 1, 10);
+    const keys = ['one-' + (Math.random() * 10000).toString(), 'two-' + (Math.random() * 10000).toString()];
+
+    cache.put(keys[0], 1, 10);
 
-    expect(await cache.has('one')).toBeTruthy();
-    expect(await cache.has('two')).toBeFalsy();
+    expect(await cache.has(keys[0])).toBeTruthy();
+    expect(await cache.has(keys[1])).toBeFalsy();
 });
 
 it('prefixes all keys with a prefix', async () => {

tests/resolvers/__snapshots__/jobs.test.ts.snap

@@ -0,0 +1,65 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`it retrieves each job story and caches it 1`] = `
+Object {
+  "jobstory:27414470": Object {
+    "expires": 0,
+    "ts": 0,
+    "value": Object {
+      "by": "yiggydyang",
+      "id": 27414470,
+      "score": 1,
+      "time": 1622998836,
+      "title": "PocketSuite Is hiring Lead Engineers, Product Designers to enrich small business",
+      "type": "job",
+      "url": "https://www.ycombinator.com/companies/pocketsuite",
+    },
+  },
+  "jobstory:27421523": Object {
+    "expires": 0,
+    "ts": 0,
+    "value": Object {
+      "by": "ifc",
+      "id": 27421523,
+      "score": 1,
+      "time": 1623067272,
+      "title": "Qventus (YC W15) Is Hiring Data Platform Engineers",
+      "type": "job",
+      "url": "https://jobs.lever.co/qventus/c0d604cf-ec1c-48ea-847d-5ffc7a67698d",
+    },
+  },
+  "jobstoryids:2:d102c7c5187b3dadeb7b29555a5d74d28a8cd87d": Object {
+    "expires": 0,
+    "ts": 0,
+    "value": Array [
+      27421523,
+      27414470,
+    ],
+  },
+}
+`;
+
+exports[`it retrieves the story data and returns it 1`] = `
+Array [
+  Object {
+    "by": "ifc",
+    "expires": 0,
+    "id": 27421523,
+    "score": 1,
+    "time": 1623067272,
+    "title": "Qventus (YC W15) Is Hiring Data Platform Engineers",
+    "type": "job",
+    "url": "https://jobs.lever.co/qventus/c0d604cf-ec1c-48ea-847d-5ffc7a67698d",
+  },
+  Object {
+    "by": "yiggydyang",
+    "expires": 0,
+    "id": 27414470,
+    "score": 1,
+    "time": 1622998836,
+    "title": "PocketSuite Is hiring Lead Engineers, Product Designers to enrich small business",
+    "type": "job",
+    "url": "https://www.ycombinator.com/companies/pocketsuite",
+  },
+]
+`;

tests/resolvers/jobs.test.ts

@@ -0,0 +1,53 @@
+/* eslint-disable no-undef */
+
+import { MemoryCache } from '@/lib/cache/MemoryCache';
+import { getResolver } from '@/resolvers/jobs';
+const hash = require('object-hash');
+
+let cache: MemoryCache;
+let resolver: any;
+const storyIds: number[] = [];
+const stories: Record<string, any>[] = [];
+
+process.env.HACKERNEWS_API_URL = 'http://127.0.0.1:3031';
+
+beforeEach(() => {
+    cache = new MemoryCache();
+    resolver = getResolver(storyIds, stories, cache);
+});
+
+it('it retrieves the story data and returns it', async () => {
+    const req = { body: { first: 2, skipText: false } };
+    const data = await resolver({}, { first: 2, skipText: false }, { req });
+
+    for (const item of data) {
+        item.expires = 0;
+    }
+
+    expect(data).toMatchSnapshot();
+});
+
+it('it retrieves the job ids and caches them', async () => {
+    const req = { body: { query: 'abc', vars: 'bbb' } };
+    const reqHash = hash(req.body);
+
+    await resolver({}, { first: 2, skipText: false }, { req });
+
+    expect(await cache.has(`jobstoryids:2:${reqHash}`)).toBeTruthy();
+});
+
+it('it retrieves each job story and caches it', async () => {
+    const req = { body: { first: 2, skipText: false, a: 1, b: 2 } };
+    const data = await resolver({}, { first: 2, skipText: false }, { req });
+
+    data.forEach(item => {
+        expect(cache.has(`jobstory:${item.id}`)).toBeTruthy();
+    });
+
+    for (const item in cache.map) {
+        cache.map[item].ts = 0;
+        cache.map[item].expires = 0;
+    }
+
+    expect(cache.map).toMatchSnapshot();
+});

tests/server/index.js

@@ -3,11 +3,21 @@ import { logger } from '@tinyhttp/logger';
 import sirv from 'sirv';
 import { readFile } from 'fs/promises';
 
+const loadFixtureFile = async filename => {
+    const file = await readFile(`${process.cwd()}/tests/fixtures/${filename}`);
+
+    return file.toString();
+};
+
 new App()
     .use(logger())
     .get('/newstories.json', async (_, res) => {
-        const file = await readFile(`${process.cwd()}/tests/fixtures/newstories.json`);
-        res.send(file.toString());
+        const data = await loadFixtureFile('newstories.json');
+        res.send(data);
+    })
+    .get('/jobstories.json', async (_, res) => {
+        const data = await loadFixtureFile('jobstories.json');
+        res.send(data);
     })
     .use(sirv('./tests/fixtures'))
     .listen(3031, () => console.log('listening on http://localhost:3031'));