feat: Update sensor handling for qn8position and adjust related tests

Author: perosb

custom_components/qvantum/binary_sensor.py

@@ -44,7 +44,6 @@ async def async_setup_entry(
         "picpin_relay_heat_l2",
         "picpin_relay_heat_l3",
         "picpin_relay_qm10",
-        "qn8position",
     ]
 
     for sensor_name in sensor_names:

custom_components/qvantum/const.py

@@ -51,6 +51,7 @@
     "use_adaptive",
     "smart_sh_mode",
     "smart_dhw_mode",
+    "qn8position",
 ]
 
 DEFAULT_DISABLED_METRICS = [
@@ -79,7 +80,6 @@
     "op_mode_sensor",
     "picpin_relay_qm10",
     "price_region",
-    "qn8position",
     "room_temp_ext",
     "dhwdemand",
     "heatingdemand",
@@ -124,7 +124,6 @@
     "enable",
     "smart_",
     "picpin_",
-    "qn8",
     "use_",
 ]
 

custom_components/qvantum/sensor.py

@@ -139,7 +139,11 @@ def _set_units_from_metric(self, metric_key: str) -> None:
         """Set appropriate units based on metric key patterns."""
         if metric_key in ["compressormeasuredspeed", "fanrpm"]:
             self._attr_native_unit_of_measurement = "rpm"
-        elif "fan" in metric_key or metric_key.startswith("gp"):
+        elif (
+            "fan" in metric_key
+            or metric_key.startswith("gp")
+            or metric_key.startswith("qn8")
+        ):
             self._attr_native_unit_of_measurement = "%"
         elif "bf1_l_min" == metric_key:
             self._attr_native_unit_of_measurement = "l/m"

custom_components/qvantum/translations/de.json

@@ -96,9 +96,6 @@
       },
       "picpin_relay_qm10": {
         "name": "Drei-Wege-Ventil, Brauchwasser/Heizung (QM10)"
-      },
-      "qn8position": {
-        "name": "Mischventil, Zusatz (QN8)"
       }
     },
     "sensor": {
@@ -193,6 +190,9 @@
       "fanrpm": {
         "name": "Lüftergeschwindigkeit"
       },
+      "qn8position": {
+        "name": "Mischventil, Zusatz (QN8)"
+      },
       "gp1_speed": {
         "name": "Heizmedium-Pumpe (GP1)"
       },

custom_components/qvantum/translations/en.json

@@ -96,9 +96,6 @@
       },
       "picpin_relay_qm10": {
         "name": "Divertingvalve, DHW/heating (QM10)"
-      },
-      "qn8position": {
-        "name": "Shuntvalve, addition (QN8)"
       }
     },
     "sensor": {
@@ -193,6 +190,9 @@
       "fanrpm": {
         "name": "Fan speed"
       },
+      "qn8position": {
+        "name": "Shuntvalve, addition (QN8)"
+      },
       "gp1_speed": {
         "name": "Circulation pump (GP1)"
       },

custom_components/qvantum/translations/nl.json

@@ -96,9 +96,6 @@
       },
       "picpin_relay_qm10": {
         "name": "Omloopklep, tapwater/verwarming (QM10)"
-      },
-      "qn8position": {
-        "name": "Sluitklep, toevoeging (QN8)"
       }
     },
     "sensor": {
@@ -193,6 +190,9 @@
       "fanrpm": {
         "name": "Ventilatorsnelheid"
       },
+      "qn8position": {
+        "name": "Sluitklep, toevoeging (QN8)"
+      },
       "gp1_speed": {
         "name": "Circulatiepomp (GP1)"
       },

custom_components/qvantum/translations/sv.json

@@ -99,9 +99,6 @@
       },
       "picpin_relay_qm10": {
         "name": "Växelventil, Varmvatten/Uppvärmning (QM10)"
-      },
-      "qn8position": {
-        "name": "Shuntventil, tillsats (QN8)"
       }
     },
     "sensor": {
@@ -196,6 +193,9 @@
       "fanrpm": {
         "name": "Fläkthastighet"
       },
+      "qn8position": {
+        "name": "Shuntventil, tillsats (QN8)"
+      },
       "gp1_speed": {
         "name": "Cirkulationspump (GP1)"
       },

tests/test_binary_sensor_working.py

@@ -203,7 +203,7 @@ def entity_id(self):
         # Check that entities were added
         assert async_add_entities.called
         entities = async_add_entities.call_args[0][0]
-        assert len(entities) == 11  # 11 sensor names
+        assert len(entities) == 10  # 10 sensor names
 
         # Check that we have the expected sensor types
         sensor_names = [
@@ -217,7 +217,6 @@ def entity_id(self):
             "picpin_relay_heat_l2",
             "picpin_relay_heat_l3",
             "picpin_relay_qm10",
-            "qn8position",
         ]
 
         for i, sensor_name in enumerate(sensor_names):

tests/test_sensor.py

@@ -69,6 +69,7 @@ def mock_coordinator():
             "fan0_10v": 75,  # Fan percentage
             "compressormeasuredspeed": 3000,  # RPM
             "bf1_l_min": 25.5,  # Flow rate
+            "qn8position": 1,  # Position sensor
         },
         "settings": {
             "tap_water_start": 3600,

tests/test_sensor_working.py

@@ -89,6 +89,7 @@ def mock_coordinator():
             "fan0_10v": 75,  # Fan percentage
             "compressormeasuredspeed": 3000,  # RPM
             "bf1_l_min": 25.5,  # Flow rate
+            "qn8position": 1,  # Position sensor
         },
         "settings": {
             "tap_water_start": 3600,