Merge pull request #105 from perplorm/strict_types

phpcs: Strict types, global functions, annotations cleanup, license block

Author: mringler

.github/workflows/ci.yml

@@ -152,7 +152,7 @@ jobs:
             check: ['PHPCS', 'Stan']
             include:
               - check: PHPCS
-                command: 'cs-check'
+                command: 'cs-check -- --exclude=SlevomatCodingStandard.TypeHints.DeclareStrictTypes,SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly'
               - check: Stan
                 command: 'stan -- -a autoload.php.dist'
               - type: query

.license

@@ -1,5 +0,0 @@
-/**
- * MIT License. This file is part of the Propel package.
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */

phpcs.xml

@@ -29,4 +29,26 @@
             <property name="phpVersion" value="8.1"/>
         </properties>
     </rule>
+
+    <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes"/>
+
+    <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly" >
+        <properties>
+            <property name="allowFallbackGlobalFunctions" value="false"/>
+            <property name="allowFallbackGlobalConstants" value="false"/>
+        </properties>
+    </rule>
+
+    <rule ref="SlevomatCodingStandard.Commenting.ForbiddenAnnotations">
+        <properties>
+            <property name="forbiddenAnnotations" type="array">
+                <element value="@author"/>
+                <element value="@created"/>
+                <element value="@copyright"/>
+                <element value="@license"/>
+                <element value="@package"/>
+                <element value="@version"/>
+            </property>
+        </properties>
+    </rule>
 </ruleset>

src/Propel/Common/Config/ConfigurationManager.php

@@ -1,10 +1,6 @@
 <?php
 
-/**
- * MIT License. This file is part of the Propel package.
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
+declare(strict_types = 1);
 
 namespace Propel\Common\Config;
 
@@ -15,13 +11,32 @@
 use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException as SymfonyInvalidConfigurationException;
 use Symfony\Component\Config\Definition\Processor;
 use Symfony\Component\Finder\Finder;
+use function array_any;
+use function array_filter;
+use function array_key_exists;
+use function array_key_first;
+use function array_keys;
+use function array_merge_recursive;
+use function array_pop;
+use function array_reduce;
+use function array_replace_recursive;
+use function array_reverse;
+use function explode;
+use function file_exists;
+use function getcwd;
+use function implode;
+use function in_array;
+use function is_dir;
+use function is_string;
+use function ksort;
+use function str_ends_with;
+use function var_export;
+use const PHP_EOL;
 
 /**
  * Class ConfigurationManager
  *
  * Class to load and process configuration files. Supported formats are: php, ini (or .properties), yaml, xml, json.
- *
- * @author Cristiano Cinotti
  */
 class ConfigurationManager
 {
@@ -303,7 +318,7 @@ private function getConfigFileNamesFromDirectory(string $path): array
         $orderedConfigFileNames = [];
         foreach ($finder as $file) {
             $realPath = $file->getRealPath();
-            $isExecutable = array_any(['propel', 'perpl'], fn ($cmd) => str_ends_with($realPath, "/bin/{$cmd}.php"));
+            $isExecutable = $realPath && array_any(['propel', 'perpl'], fn ($cmd) => str_ends_with($realPath, "/bin/{$cmd}.php"));
             if ($isExecutable) {
                 continue;
             }

src/Propel/Common/Config/Exception/ExceptionInterface.php

@@ -1,10 +1,6 @@
 <?php
 
-/**
- * MIT License. This file is part of the Propel package.
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
+declare(strict_types = 1);
 
 namespace Propel\Common\Config\Exception;
 

src/Propel/Common/Config/Exception/IniParseException.php

@@ -1,10 +1,6 @@
 <?php
 
-/**
- * MIT License. This file is part of the Propel package.
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
+declare(strict_types = 1);
 
 namespace Propel\Common\Config\Exception;
 

src/Propel/Common/Config/Exception/InputOutputException.php

@@ -1,10 +1,6 @@
 <?php
 
-/**
- * MIT License. This file is part of the Propel package.
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
+declare(strict_types = 1);
 
 namespace Propel\Common\Config\Exception;
 

src/Propel/Common/Config/Exception/InvalidArgumentException.php

@@ -1,10 +1,6 @@
 <?php
 
-/**
- * MIT License. This file is part of the Propel package.
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
+declare(strict_types = 1);
 
 namespace Propel\Common\Config\Exception;
 

src/Propel/Common/Config/Exception/InvalidConfigurationException.php

@@ -1,10 +1,6 @@
 <?php
 
-/**
- * MIT License. This file is part of the Propel package.
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
+declare(strict_types = 1);
 
 namespace Propel\Common\Config\Exception;
 

src/Propel/Common/Config/Exception/JsonParseException.php

@@ -1,13 +1,17 @@
 <?php
 
-/**
- * MIT License. This file is part of the Propel package.
- * For the full copyright and license information, please view the LICENSE
- * file that was distributed with this source code.
- */
+declare(strict_types = 1);
 
 namespace Propel\Common\Config\Exception;
 
+use function function_exists;
+use function json_last_error_msg;
+use const JSON_ERROR_CTRL_CHAR;
+use const JSON_ERROR_DEPTH;
+use const JSON_ERROR_STATE_MISMATCH;
+use const JSON_ERROR_SYNTAX;
+use const JSON_ERROR_UTF8;
+
 class JsonParseException extends RuntimeException implements ExceptionInterface
 {
     /**