comment 4

Signed-off-by: Mahmoud Shahrokni <seyedmahmoud.shahrokni@amadeus.com>

Author: shahrokni

.github/workflows/ci.yml

@@ -109,12 +109,7 @@ jobs:
         run: |
           # Handshake with server on port 8080
           percli login http://localhost:8080
-          PLUGINS=("table" "tracetable")
-          for plugin in "${PLUGINS[@]}"; do
-            percli plugin start "./$plugin" &
-            sleep 10           
-            npm run test:ci --prefix e2e -- "tests/$plugin"
-          done
+          go run scripts/manage_plugins/manage_plugins.go
 
   type-check:
     name: "type-check"

scripts/manage_plugins/manage_plugins.go

@@ -0,0 +1,67 @@
+package main
+
+import (
+	"context"
+	"fmt"
+	"os"
+	"os/exec"
+	"os/signal"
+	"sync"
+	"syscall"
+	"time"
+)
+
+func main() {
+	plugins := []string{"table", "tracetable"}
+	ctx, cancel := context.WithCancel(context.Background())
+	defer cancel()
+
+	// Handle OS signals for termination (Ctrl+C, CI cancellation)
+	//  Signal(0xf) // 15 and Signal(0x2) // 2
+	sigChan := make(chan os.Signal, 1)
+	signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM)
+
+	// Let's wait and catch the termination signals
+	// If any of these signals are received, we will cancel the context which will stop all running plugin processes
+	go func() {
+		<-sigChan
+		fmt.Println("\nTermination signal received. Cleaning up...")
+		cancel()
+	}()
+
+	// Let's make sure that the main function waits for all plugin processes to finish before exiting
+	var wg sync.WaitGroup
+
+	for _, plugin := range plugins {
+		wg.Add(1)
+		go func(p string) {
+			defer wg.Done()
+
+			// Start percli plugin in the background using the context
+			cmd := exec.CommandContext(ctx, "percli", "plugin", "start", "./"+p)
+			cmd.Stdout = os.Stdout
+			cmd.Stderr = os.Stderr
+
+			fmt.Printf("Starting plugin: %s\n", p)
+			if err := cmd.Start(); err != nil {
+				fmt.Errorf("failed to start %s: %v\n", p, err)
+				return
+			}
+
+			// Instead of a blind sleep 10, could we do a health logic here? I am not sure!
+			// Plugins start on an arbitrary port, how could we check if they are ruining or not?!
+			time.Sleep(10 * time.Second)
+
+			// Run your test command
+			testCmd := exec.Command("npm", "run", "test:ci", "--prefix", "e2e", "--", "tests/"+p)
+			testCmd.Stdout = os.Stdout
+			testCmd.Stderr = os.Stderr
+			if err := testCmd.Run(); err != nil {
+				fmt.Errorf("tests failed for plugin %s: %v\n", p, err)
+			}
+		}(plugin)
+	}
+
+	wg.Wait()
+	fmt.Println("All plugin tests completed.")
+}