fix: LSM Bond Factor Validation (#637)

* bond factor fix

* changelog

* tests

Author: kruspy

CHANGELOG.md

@@ -36,6 +36,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ## [Unreleased]
 
+### Bug Fixes
+
+- [#637](https://github.com/persistenceOne/pstake-native/pull/637) LSM bond factor validation fix.
+
 ## [v2.3.0] - 2023-09-06
 
 ### Features

x/liquidstakeibc/types/msgs.go

@@ -298,8 +298,8 @@ func (m *MsgUpdateHostChain) ValidateBasic() error {
 			}
 
 			// -1 is the default bond factor value
-			if !bondFactor.Equal(sdk.NewDec(-1)) || bondFactor.GTE(sdk.ZeroDec()) {
-				return sdkerrors.ErrInvalidRequest.Wrapf("invalid validator bond factor value should be -1 == bond factor >= 0")
+			if bondFactor.LT(sdk.ZeroDec()) && !bondFactor.Equal(sdk.NewDec(-1)) {
+				return sdkerrors.ErrInvalidRequest.Wrapf("invalid validator bond factor value should be bond_factor == -1 || bond_factor >= 0")
 			}
 		case KeyMinimumDeposit:
 			minimumDeposit, ok := sdk.NewIntFromString(update.Value)

x/liquidstakeibc/types/msgs_test.go

@@ -231,6 +231,24 @@ func TestMsgUpdateHostChain(t *testing.T) {
 		}, {
 			Key:   types.KeyMinimumDeposit,
 			Value: "1",
+		}, {
+			Key:   types.KeyLSMValidatorCap,
+			Value: "0",
+		}, {
+			Key:   types.KeyLSMValidatorCap,
+			Value: "1",
+		}, {
+			Key:   types.KeyLSMValidatorCap,
+			Value: "0.5",
+		}, {
+			Key:   types.KeyLSMBondFactor,
+			Value: "-1",
+		}, {
+			Key:   types.KeyLSMBondFactor,
+			Value: "250",
+		}, {
+			Key:   types.KeyLSMBondFactor,
+			Value: "0",
 		}, {
 			Key:   types.KeyActive,
 			Value: "true",
@@ -307,6 +325,18 @@ func TestMsgUpdateHostChain(t *testing.T) {
 		}, {
 			Key:   types.KeyRedemptionFee,
 			Value: "invalidDec",
+		}, {
+			Key:   types.KeyLSMValidatorCap,
+			Value: "-0.5",
+		}, {
+			Key:   types.KeyLSMValidatorCap,
+			Value: "2",
+		}, {
+			Key:   types.KeyLSMBondFactor,
+			Value: "-0.5",
+		}, {
+			Key:   types.KeyLSMBondFactor,
+			Value: "-1.5",
 		}, {
 			Key:   types.KeyMinimumDeposit,
 			Value: "0",