Skip to content

Commit 951572b

Browse files
feat(metrics): remove dst_zone label, reduce number of latency buckets
The buckets of the metrics are reduced to: 1, 10, 50, 100, 200, 300, 400, 500, 1000, 5000, 10000 zone (availability zone) is totally removed
1 parent 5c5b9a9 commit 951572b

File tree

3 files changed

+2
-16
lines changed

3 files changed

+2
-16
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ env:
4949
CARGO_INCREMENTAL: 0
5050
CARGO_NET_RETRY: 10
5151
RUSTFLAGS: "-D warnings -A deprecated"
52-
RUSTUP_MAX_RETRIES: 11
52+
RUSTUP_MAX_RETRIES: 19
5353

5454
concurrency:
5555
group: ${{ github.workflow }}-${{ github.head_ref }}

linkerd/app/core/src/metrics.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ where
142142
let mut out = format!("{}_{}=\"{}\"", prefix, k0, v0);
143143

144144
for (k, v) in labels_iter {
145-
if k == "pod" || k == "pod_template_hash" {
145+
if k == "pod" || k == "pod_template_hash" || k == "zone" {
146146
continue;
147147
}
148148

linkerd/metrics/src/latency.rs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,30 +6,16 @@ use super::histogram::{Bounds, Bucket, Histogram};
66
/// milliseconds.
77
pub const BOUNDS: &Bounds = &Bounds(&[
88
Bucket::Le(1.0),
9-
Bucket::Le(2.0),
10-
Bucket::Le(3.0),
11-
Bucket::Le(4.0),
12-
Bucket::Le(5.0),
139
Bucket::Le(10.0),
14-
Bucket::Le(20.0),
15-
Bucket::Le(30.0),
16-
Bucket::Le(40.0),
1710
Bucket::Le(50.0),
1811
Bucket::Le(100.0),
1912
Bucket::Le(200.0),
2013
Bucket::Le(300.0),
2114
Bucket::Le(400.0),
2215
Bucket::Le(500.0),
2316
Bucket::Le(1_000.0),
24-
Bucket::Le(2_000.0),
25-
Bucket::Le(3_000.0),
26-
Bucket::Le(4_000.0),
2717
Bucket::Le(5_000.0),
2818
Bucket::Le(10_000.0),
29-
Bucket::Le(20_000.0),
30-
Bucket::Le(30_000.0),
31-
Bucket::Le(40_000.0),
32-
Bucket::Le(50_000.0),
3319
// A final upper bound.
3420
Bucket::Inf,
3521
]);

0 commit comments

Comments
 (0)