Skip to content

Commit d76dda3

Browse files
build(deps): bump the opentelemetry group with 2 updates (linkerd#3356)
Bumps the opentelemetry group with 2 updates: [opentelemetry](https://github.com/open-telemetry/opentelemetry-rust) and [opentelemetry_sdk](https://github.com/open-telemetry/opentelemetry-rust). Updates `opentelemetry` from 0.26.0 to 0.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry-0.26.0...opentelemetry-0.27.0) Updates `opentelemetry_sdk` from 0.26.0 to 0.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry_sdk-0.26.0...opentelemetry_sdk-0.27.0) --- updated-dependencies: - dependency-name: opentelemetry dependency-type: direct:production update-type: version-update:semver-minor dependency-group: opentelemetry - dependency-name: opentelemetry_sdk dependency-type: direct:production update-type: version-update:semver-minor dependency-group: opentelemetry ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oliver Gould <ver@buoyant.io>
1 parent 7b78212 commit d76dda3

File tree

6 files changed

+35
-36
lines changed

6 files changed

+35
-36
lines changed

Cargo.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2873,9 +2873,9 @@ dependencies = [
28732873

28742874
[[package]]
28752875
name = "opentelemetry"
2876-
version = "0.26.0"
2876+
version = "0.27.0"
28772877
source = "registry+https://github.com/rust-lang/crates.io-index"
2878-
checksum = "570074cc999d1a58184080966e5bd3bf3a9a4af650c3b05047c2621e7405cd17"
2878+
checksum = "0f3cebff57f7dbd1255b44d8bddc2cebeb0ea677dbaa2e25a3070a91b318f660"
28792879
dependencies = [
28802880
"futures-core",
28812881
"futures-sink",
@@ -2898,9 +2898,9 @@ dependencies = [
28982898

28992899
[[package]]
29002900
name = "opentelemetry_sdk"
2901-
version = "0.26.0"
2901+
version = "0.27.0"
29022902
source = "registry+https://github.com/rust-lang/crates.io-index"
2903-
checksum = "d2c627d9f4c9cdc1f21a29ee4bfbd6028fcb8bcf2a857b43f3abdf72c9c862f3"
2903+
checksum = "27b742c1cae4693792cc564e58d75a2a0ba29421a34a85b50da92efa89ecb2bc"
29042904
dependencies = [
29052905
"async-trait",
29062906
"futures-channel",

linkerd/opentelemetry/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ http-body = "0.4"
1313
linkerd-error = { path = "../error" }
1414
linkerd-metrics = { path = "../metrics" }
1515
linkerd-trace-context = { path = "../trace-context" }
16-
opentelemetry = { version = "0.26", default-features = false, features = ["trace"] }
17-
opentelemetry_sdk = { version = "0.26", default-features = false, features = ["trace"] }
16+
opentelemetry = { version = "0.27", default-features = false, features = ["trace"] }
17+
opentelemetry_sdk = { version = "0.27", default-features = false, features = ["trace"] }
1818
opentelemetry-proto = { path = "../../opentelemetry-proto" }
1919
tonic = { version = "0.10", default-features = false, features = [
2020
"prost",

linkerd/opentelemetry/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,6 @@ fn convert_span(span: ExportSpan) -> Result<SpanData, Error> {
257257
TraceState::NONE,
258258
),
259259
events: Default::default(),
260-
instrumentation_lib: Default::default(),
260+
instrumentation_scope: Default::default(),
261261
})
262262
}

opentelemetry-proto/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ Vendored from https://github.com/open-telemetry/opentelemetry-rust/.
1414
[dependencies]
1515
tonic = { version = "0.10", features = ["codegen", "prost", "transport"] }
1616
prost = "0.12"
17-
opentelemetry = { version = "0.26", default-features = false, features = ["trace"] }
18-
opentelemetry_sdk = { version = "0.26", default-features = false, features = ["trace"] }
17+
opentelemetry = { version = "0.27", default-features = false, features = ["trace"] }
18+
opentelemetry_sdk = { version = "0.27", default-features = false, features = ["trace"] }
1919

2020
[dev-dependencies]
21-
opentelemetry = { version = "0.26", default-features = false, features = ["trace", "testing"] }
21+
opentelemetry = { version = "0.27", default-features = false, features = ["trace", "testing"] }
2222
tonic-build = { version = "0.10", default-features = false, features = ["prost"] }
2323

2424
[lib]

opentelemetry-proto/src/transform/common.rs

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,17 @@ impl From<&opentelemetry_sdk::Resource> for ResourceAttributesWithSchema {
2727

2828
impl
2929
From<(
30-
opentelemetry_sdk::InstrumentationLibrary,
30+
opentelemetry::InstrumentationScope,
3131
Option<Cow<'static, str>>,
3232
)> for InstrumentationScope
3333
{
3434
fn from(
3535
data: (
36-
opentelemetry_sdk::InstrumentationLibrary,
36+
opentelemetry::InstrumentationScope,
3737
Option<Cow<'static, str>>,
3838
),
3939
) -> Self {
40-
let (library, target) = data;
40+
let (scope, target) = data;
4141
if let Some(t) = target {
4242
InstrumentationScope {
4343
name: t.to_string(),
@@ -46,10 +46,12 @@ impl
4646
..Default::default()
4747
}
4848
} else {
49+
let Attributes(attributes) =
50+
Attributes::from(scope.attributes().cloned().collect::<Vec<_>>());
4951
InstrumentationScope {
50-
name: library.name.into_owned(),
51-
version: library.version.map(Cow::into_owned).unwrap_or_default(),
52-
attributes: Attributes::from(library.attributes).0,
52+
name: scope.name().to_string(),
53+
version: scope.version().map(ToString::to_string).unwrap_or_default(),
54+
attributes,
5355
..Default::default()
5456
}
5557
}
@@ -58,17 +60,17 @@ impl
5860

5961
impl
6062
From<(
61-
&opentelemetry_sdk::InstrumentationLibrary,
63+
&opentelemetry::InstrumentationScope,
6264
Option<Cow<'static, str>>,
6365
)> for InstrumentationScope
6466
{
6567
fn from(
6668
data: (
67-
&opentelemetry_sdk::InstrumentationLibrary,
69+
&opentelemetry::InstrumentationScope,
6870
Option<Cow<'static, str>>,
6971
),
7072
) -> Self {
71-
let (library, target) = data;
73+
let (scope, target) = data;
7274
if let Some(t) = target {
7375
InstrumentationScope {
7476
name: t.to_string(),
@@ -77,14 +79,12 @@ impl
7779
..Default::default()
7880
}
7981
} else {
82+
let Attributes(attributes) =
83+
Attributes::from(scope.attributes().cloned().collect::<Vec<_>>());
8084
InstrumentationScope {
81-
name: library.name.to_string(),
82-
version: library
83-
.version
84-
.as_ref()
85-
.map(ToString::to_string)
86-
.unwrap_or_default(),
87-
attributes: Attributes::from(library.attributes.clone()).0,
85+
name: scope.name().to_string(),
86+
version: scope.version().map(ToString::to_string).unwrap_or_default(),
87+
attributes,
8888
..Default::default()
8989
}
9090
}
@@ -121,7 +121,9 @@ impl From<Value> for AnyValue {
121121
Array::I64(vals) => array_into_proto(vals),
122122
Array::F64(vals) => array_into_proto(vals),
123123
Array::String(vals) => array_into_proto(vals),
124+
_ => ArrayValue::default(),
124125
})),
126+
_ => None,
125127
},
126128
}
127129
}

opentelemetry-proto/src/transform/trace.rs

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,11 @@ impl ResourceSpans {
9696
schema_url: resource.schema_url.clone().unwrap_or_default(),
9797
scope_spans: vec![ScopeSpans {
9898
schema_url: source_span
99-
.instrumentation_lib
100-
.schema_url
101-
.as_ref()
99+
.instrumentation_scope
100+
.schema_url()
102101
.map(ToString::to_string)
103102
.unwrap_or_default(),
104-
scope: Some((source_span.instrumentation_lib, None).into()),
103+
scope: Some((source_span.instrumentation_scope, None).into()),
105104
spans: vec![Span {
106105
trace_id: source_span.span_context.trace_id().to_bytes().to_vec(),
107106
span_id: source_span.span_context.span_id().to_bytes().to_vec(),
@@ -153,9 +152,8 @@ pub fn group_spans_by_resource_and_scope(
153152
// Group spans by their instrumentation library
154153
let scope_map = spans.iter().fold(
155154
HashMap::new(),
156-
|mut scope_map: HashMap<&opentelemetry_sdk::InstrumentationLibrary, Vec<&SpanData>>,
157-
span| {
158-
let instrumentation = &span.instrumentation_lib;
155+
|mut scope_map: HashMap<&opentelemetry::InstrumentationScope, Vec<&SpanData>>, span| {
156+
let instrumentation = &span.instrumentation_scope;
159157
scope_map.entry(instrumentation).or_default().push(span);
160158
scope_map
161159
},
@@ -192,11 +190,10 @@ mod tests {
192190
use opentelemetry::trace::{
193191
SpanContext, SpanId, SpanKind, Status, TraceFlags, TraceId, TraceState,
194192
};
195-
use opentelemetry::KeyValue;
193+
use opentelemetry::{InstrumentationScope, KeyValue};
196194
use opentelemetry_sdk::export::trace::SpanData;
197195
use opentelemetry_sdk::resource::Resource;
198196
use opentelemetry_sdk::trace::{SpanEvents, SpanLinks};
199-
use opentelemetry_sdk::InstrumentationLibrary;
200197
use std::borrow::Cow;
201198
use std::time::{Duration, SystemTime};
202199

@@ -221,7 +218,7 @@ mod tests {
221218
events: SpanEvents::default(),
222219
links: SpanLinks::default(),
223220
status: Status::Unset,
224-
instrumentation_lib: InstrumentationLibrary::builder(instrumentation_name).build(),
221+
instrumentation_scope: InstrumentationScope::builder(instrumentation_name).build(),
225222
}
226223
}
227224

0 commit comments

Comments
 (0)