Fix perspective-viewer unlocked expressions update and removed UI expect

Signed-off-by: Andrew Stein <steinlink@gmail.com>

Author: texodus

rust/perspective-client/src/rust/client.rs

@@ -232,7 +232,7 @@ impl Client {
         {
             tracing::error!("{}", message);
         } else {
-            tracing::warn!("Received unsolicited server message");
+            tracing::debug!("Received unsolicited server response: {}", msg);
         }
 
         Ok(false)

rust/perspective-viewer/src/rust/components/column_selector/filter_column.rs

@@ -490,7 +490,7 @@ impl Component for FilterColumn {
             },
         };
 
-        let final_col_type = col_type.expect("Unknown column");
+        let final_col_type = col_type.unwrap_or(perspective_client::ColumnType::Integer);
 
         html! {
             <div

rust/perspective-viewer/src/rust/components/column_selector/pivot_column.rs

@@ -68,7 +68,7 @@ impl Component for PivotColumn {
             .session
             .metadata()
             .get_column_table_type(&ctx.props().column)
-            .expect("Unknown column");
+            .unwrap_or(perspective_client::ColumnType::Integer);
 
         html! {
             <div

rust/perspective-viewer/src/rust/components/column_selector/sort_column.rs

@@ -111,7 +111,7 @@ impl Component for SortColumn {
             .session
             .metadata()
             .get_column_table_type(&ctx.props().sort.0.to_owned())
-            .expect("Unknown column");
+            .unwrap_or(perspective_client::ColumnType::Integer);
 
         html! {
             <div

rust/perspective-viewer/src/rust/session.rs

@@ -605,7 +605,7 @@ impl Session {
     }
 
     async fn validate_view_config(&self) -> ApiResult<()> {
-        let config = self.borrow().config.clone();
+        let mut config = self.borrow().config.clone();
         let table_columns = self
             .metadata()
             .get_table_columns()
@@ -623,13 +623,11 @@ impl Session {
             .ok_or_else(|| apierror!(NoTableError))?
             .clone();
 
-        let valid_recs = table.validate_expressions(config.expressions).await?;
-        let expression_names = self.metadata_mut().update_expressions(&valid_recs)?;
-
-        // re-fetch config after `await`; `expressions` and `all_columns` are ok,
-        // but `config` may have changed as it is unlocked.
-        let mut config = self.borrow().config.clone();
+        let valid_recs = table
+            .validate_expressions(config.expressions.clone())
+            .await?;
 
+        let expression_names = self.metadata_mut().update_expressions(&valid_recs)?;
         if config.columns.is_empty() {
             config.columns = table_columns.into_iter().map(Some).collect();
         }