Skip to content

Commit 7ce821f

Browse files
authored
Merge pull request #30 from cfriedtpv/kb/4299/server-fix-small-compiler-warnings-and-errors
Kb/4299/server fix small compiler warnings and errors
2 parents 900b537 + c260254 commit 7ce821f

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

hal/properties.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4550,7 +4550,7 @@ static int hdlr_fpga_about_cmp_time (const char* data, char* ret) {
45504550
}
45514551

45524552
static int hdlr_fpga_about_conf_info (const char* data, char* ret){
4553-
uint64_t old_val;
4553+
uint32_t old_val;
45544554
read_hps_reg ( "sys18", &old_val);
45554555

45564556
sprintf(ret, "config. info. 0x%02x \n", old_val);
@@ -4565,7 +4565,7 @@ static int hdlr_fpga_about_serial (const char* data, char* ret){
45654565
read_hps_reg ( "sys17", &old_val2);
45664566

45674567
//append values
4568-
old_val = (old_val2 << 32) | old_val1;
4568+
old_val = ((uint64_t)old_val2 << 32) | (uint64_t)old_val1;
45694569

45704570
sprintf(ret, "serial number 0x%02x%02x \n", old_val2, old_val1);
45714571
return RETURN_SUCCESS;
@@ -4601,7 +4601,7 @@ static int hdlr_fpga_about_fw_ver (const char* data, char* ret) {
46014601
old_val2 = old_val2 & 0xff;
46024602

46034603
//append values
4604-
old_val = (old_val2 << 32) | old_val1;
4604+
old_val = ((uint64_t)old_val2 << 32) | (uint64_t)old_val1;
46054605

46064606

46074607
sprintf(ret, "ver. 0x%02x%02x \n", old_val2, old_val1);

server.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,16 @@ extern int verbose;
103103

104104
// main loop
105105
int main(int argc, char *argv[]) {
106+
107+
int ret = 0;
108+
int i = 0;
109+
cmd_t cmd;
110+
106111
verbose = 0;
107112
fd_set rfds;
108113

109114
// check for firmware version
110-
for( int i = 1; i < argc; i++ ) {
115+
for( i = 1; i < argc; i++ ) {
111116
if (strcmp(argv[i], "-v") == 0) {
112117
printf("Branch: %s\n", VERSIONGITBRANCH);
113118
printf("Revision: %s\n", VERSIONGITREVISION);
@@ -127,10 +132,6 @@ int main(int argc, char *argv[]) {
127132
}
128133
}
129134

130-
int ret = 0;
131-
int i = 0;
132-
cmd_t cmd;
133-
134135
PRINT( INFO, "Starting Crimson server\n");
135136

136137
server_init_led();

0 commit comments

Comments
 (0)