Skip to content

Commit b1f283e

Browse files
Fix release signing: use Windows runner and dotnet tool restore (#391)
The sign tool (dotnet/sign) is Windows-only — all binaries target net8.0/win-x64. Switch the release job to windows-latest and adopt the same pattern as Akka.Persistence.Azure: - Pin sign 0.9.1-beta.25181.2 in .config/dotnet-tools.json - Replace dotnet tool install --global with dotnet tool restore - Invoke via dotnet sign (local tool) with PowerShell syntax - Use --base-directory with glob pattern for package discovery
1 parent 2421626 commit b1f283e

File tree

2 files changed

+26
-16
lines changed

2 files changed

+26
-16
lines changed

.config/dotnet-tools.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
{
22
"version": 1,
33
"isRoot": true,
4-
"tools": {}
5-
}
4+
"tools": {
5+
"sign": {
6+
"version": "0.9.1-beta.25181.2",
7+
"commands": [
8+
"sign"
9+
],
10+
"rollForward": false
11+
}
12+
}
13+
}

.github/workflows/release.yaml

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ permissions:
1212
jobs:
1313
release:
1414
name: Build, Sign, and Publish
15-
runs-on: ubuntu-latest
15+
runs-on: windows-latest
1616
environment: signing
1717
env:
1818
CODE_SIGN_KEY_VAULT: ${{ secrets.CODE_SIGN_KEY_VAULT }}
@@ -29,11 +29,15 @@ jobs:
2929
with:
3030
global-json-file: "./global.json"
3131

32+
- name: Restore .NET tools
33+
run: dotnet tool restore
34+
3235
- name: Update release notes
3336
shell: pwsh
3437
run: ./build.ps1
3538

3639
- name: Extract version from tag
40+
shell: bash
3741
id: version
3842
run: echo "version=${GITHUB_REF_NAME}" >> "$GITHUB_OUTPUT"
3943

@@ -51,21 +55,19 @@ jobs:
5155
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
5256
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
5357

54-
- name: Install dotnet-sign
55-
if: env.CODE_SIGN_KEY_VAULT != ''
56-
run: dotnet tool install --global sign --version 0.9.*
57-
5858
- name: Sign NuGet packages
5959
if: env.CODE_SIGN_KEY_VAULT != ''
60-
run: >
61-
sign code azure-key-vault
62-
./bin/nuget/*.nupkg
63-
--publisher-name "Petabridge"
64-
--description "TurboMqtt"
65-
--description-url "https://github.com/petabridge/TurboMqtt"
66-
--azure-key-vault-url "${{ secrets.CODE_SIGN_KEY_VAULT }}"
67-
--azure-key-vault-certificate "${{ secrets.CODE_SIGN_CERT_NAME }}"
68-
-v Information
60+
shell: pwsh
61+
run: |
62+
dotnet sign code azure-key-vault `
63+
"**/*.nupkg" `
64+
--base-directory "$env:GITHUB_WORKSPACE/bin/nuget" `
65+
--publisher-name "Petabridge" `
66+
--description "TurboMqtt" `
67+
--description-url "https://github.com/petabridge/TurboMqtt" `
68+
--azure-key-vault-certificate "${{ secrets.CODE_SIGN_CERT_NAME }}" `
69+
--azure-key-vault-url "${{ secrets.CODE_SIGN_KEY_VAULT }}" `
70+
-v Information
6971
7072
- name: Push to NuGet.org
7173
run: >

0 commit comments

Comments
 (0)