Cant change grid constraint size if you are loading inventory v3

[kyle-wannacott]

Changing grid constraint size has no effect if you're loading your inventory from persistent data because the grid size is stored and overrides your grid constraint setting (I think?). Which means you basically cant change your grid size after first setting it; if you are loading your inventory.

[peter-kish]

Not sure I understand this one. So what you're doing is

1. Save (serialize) the inventory which has a grid constraint with size X
2. Set the grid constraint size to Y
3. Load the inventory (deserialize). The grid constraint size also gets loaded and is set back to X.

Is this correct? Because this looks like expected behavior to me.

[kyle-wannacott]

Is this correct?

Yeah.

Because this looks like expected behavior to me.

Well it means you better make the right design choice about your grid size upfront, because once its in production you can't change it; not without wiping peoples data. Like lets say you realize the size is too small because people are complaining and want to expand it, you cant.

[peter-kish]

Aah, so we're talking about changing the grid constraint size after the inventory has been loaded. That can depend on the contents of the inventory, because if the size is set to a value which can't contain all the items, the operation will be unsuccessful.
But I guess that shouldn't happen if you're increasing the inventory size, which is what you are doing, right?

[kyle-wannacott]

Aah, so we're talking about changing the grid constraint size after the inventory has been loaded. That can depend on the contents of the inventory, because if the size is set to a value which can't contain all the items, the operation will be unsuccessful.

Yeah, I have thought about that.

Ideally it would handle both cases, but I acknowledge the grid constraint being set smaller is way more complicated and probably less important... you could not display inventory items that are outside the grid size and then when room becomes available next time it is loaded assuming you have enough space from moving stuff out of the grid; inventory items would be displayed 🤔

But the case of setting the grid constraint larger should be easy in theory 🤞🏻; just a matter of checking if the grid constraint setting is larger than the size from the loaded inventory and setting the size to the larger grid constaint if it is.

[peter-kish]

just a matter of checking if the grid constraint setting is larger than the size from the loaded inventory and setting the size to the larger grid constaint if it is.

In fact, every time the size changes there is a check that verifies that all items can still fit inside the inventory. That way the new size should be accepted even if it is smaller, as long as all the items still fit.