Add Localization Support and Language Switching Feature

	•	Introduced multilingual support with localizations for English (en), Greek (el), and Albanian (sq).
	•	Added Localizable.xcstrings file for managing translated strings.
	•	Implemented language switching in the app’s menu with emoji flag options.
	•	Created a Bundle extension for dynamic language switching without restarting the app.
	•	Updated UI to reflect the selected language dynamically.
	•	Enhanced localization handling for menu items, alerts, and messages.
	•	Modified Info.plist to include supported localizations.
	•	Improved loadImage function for better error handling and added priority control.
	•	Ensured all strings are extracted for localization consistency.

This commit enhances user experience by allowing seamless language customization.

Author: peterdsp

Moti/Moti.xcodeproj/project.pbxproj

@@ -7,6 +7,7 @@
 	objects = {
 
 /* Begin PBXBuildFile section */
+		2AD9D0392CE6104D00B9873A /* Localizable.xcstrings in Resources */ = {isa = PBXBuildFile; fileRef = 2AD9D0382CE6104D00B9873A /* Localizable.xcstrings */; };
 		2C062A512C7A97CF0010D9F4 /* Moti.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2C062A502C7A97CF0010D9F4 /* Moti.swift */; };
 		2C062A532C7A97CF0010D9F4 /* ContentView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2C062A522C7A97CF0010D9F4 /* ContentView.swift */; };
 		2C062A552C7A97CF0010D9F4 /* Item.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2C062A542C7A97CF0010D9F4 /* Item.swift */; };
@@ -38,6 +39,7 @@
 
 /* Begin PBXFileReference section */
 		1CD041F23F0293042067A6C1 /* Pods-Moti.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Moti.release.xcconfig"; path = "Target Support Files/Pods-Moti/Pods-Moti.release.xcconfig"; sourceTree = "<group>"; };
+		2AD9D0382CE6104D00B9873A /* Localizable.xcstrings */ = {isa = PBXFileReference; lastKnownFileType = text.json.xcstrings; path = Localizable.xcstrings; sourceTree = "<group>"; };
 		2C062A4D2C7A97CF0010D9F4 /* Moti.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Moti.app; sourceTree = BUILT_PRODUCTS_DIR; };
 		2C062A502C7A97CF0010D9F4 /* Moti.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Moti.swift; sourceTree = "<group>"; };
 		2C062A522C7A97CF0010D9F4 /* ContentView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ContentView.swift; sourceTree = "<group>"; };
@@ -157,6 +159,7 @@
 		2C062A6C2C7AA2FF0010D9F4 /* Supporting Files */ = {
 			isa = PBXGroup;
 			children = (
+				2AD9D0382CE6104D00B9873A /* Localizable.xcstrings */,
 			);
 			path = "Supporting Files";
 			sourceTree = "<group>";
@@ -201,7 +204,7 @@
 			attributes = {
 				BuildIndependentTargetsInParallel = 1;
 				LastSwiftUpdateCheck = 1540;
-				LastUpgradeCheck = 1540;
+				LastUpgradeCheck = 1610;
 				TargetAttributes = {
 					2C062A4C2C7A97CF0010D9F4 = {
 						CreatedOnToolsVersion = 15.4;
@@ -215,6 +218,9 @@
 			knownRegions = (
 				en,
 				Base,
+				shq,
+				el,
+				sq,
 			);
 			mainGroup = 2C062A442C7A97CF0010D9F4;
 			productRefGroup = 2C062A4E2C7A97CF0010D9F4 /* Products */;
@@ -233,6 +239,7 @@
 			files = (
 				2C062A5A2C7A97D00010D9F4 /* Preview Assets.xcassets in Resources */,
 				2CADE6792C833A17001FE1C2 /* GoogleService-Info.plist in Resources */,
+				2AD9D0392CE6104D00B9873A /* Localizable.xcstrings in Resources */,
 				2C062A572C7A97D00010D9F4 /* Assets.xcassets in Resources */,
 				2C062A662C7A9FCB0010D9F4 /* Info.plist in Resources */,
 			);
@@ -333,6 +340,7 @@
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				COPY_PHASE_STRIP = NO;
+				DEAD_CODE_STRIPPING = YES;
 				DEBUG_INFORMATION_FORMAT = dwarf;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				ENABLE_TESTABILITY = YES;
@@ -359,6 +367,7 @@
 				ONLY_ACTIVE_ARCH = YES;
 				SDKROOT = macosx;
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "DEBUG $(inherited)";
+				SWIFT_EMIT_LOC_STRINGS = YES;
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
 			};
 			name = Debug;
@@ -397,6 +406,7 @@
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				COPY_PHASE_STRIP = NO;
+				DEAD_CODE_STRIPPING = YES;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				ENABLE_NS_ASSERTIONS = NO;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
@@ -416,6 +426,7 @@
 				MTL_FAST_MATH = YES;
 				SDKROOT = macosx;
 				SWIFT_COMPILATION_MODE = wholemodule;
+				SWIFT_EMIT_LOC_STRINGS = YES;
 			};
 			name = Release;
 		};
@@ -430,6 +441,7 @@
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
 				CURRENT_PROJECT_VERSION = 1;
+				DEAD_CODE_STRIPPING = YES;
 				DEVELOPMENT_ASSET_PATHS = "\"Moti/Preview Content\"";
 				DEVELOPMENT_TEAM = R8JF2W45R3;
 				ENABLE_HARDENED_RUNTIME = YES;
@@ -463,6 +475,7 @@
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
 				CURRENT_PROJECT_VERSION = 1;
+				DEAD_CODE_STRIPPING = YES;
 				DEVELOPMENT_ASSET_PATHS = "\"Moti/Preview Content\"";
 				DEVELOPMENT_TEAM = R8JF2W45R3;
 				ENABLE_HARDENED_RUNTIME = YES;

Moti/Moti.xcodeproj/xcshareddata/xcschemes/Moti.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1540"
+   LastUpgradeVersion = "1610"
    version = "1.7">
    <BuildAction
       parallelizeBuildables = "YES"

Moti/Moti/Info.plist

@@ -21,6 +21,13 @@
     <key>NSLocationUsageDescription</key>
     <string>Tempethéra requires access to your location to provide accurate weather information.</string>
 
+    <key>CFBundleLocalizations</key>
+    <array>
+        <string>en</string>
+        <string>el</string>
+        <string>sq</string>
+    </array>
+    
     <key>NSAppTransportSecurity</key>
     <dict>
         <key>NSExceptionDomains</key>

Moti/Moti/Moti.swift

@@ -32,6 +32,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
     private var cancellables = Set<AnyCancellable>()
     private var globalClickMonitor: Any?
     private var isAlwaysOnTop = false
+    @Published var currentLanguage: String = "en"
 
     func applicationDidFinishLaunching(_ notification: Notification) {
         setupStatusItem()
@@ -85,19 +86,55 @@ class AppDelegate: NSObject, NSApplicationDelegate {
 
     private func showContextMenu(_ sender: NSStatusBarButton) {
         let menu = NSMenu()
+
+        // Refresh option
         menu.addItem(
-            NSMenuItem(title: "Refresh", action: #selector(refreshWeather), keyEquivalent: "r"))
+            NSMenuItem(
+                title: NSLocalizedString("refresh", comment: ""), action: #selector(refreshWeather),
+                keyEquivalent: "r"))
+
+        // Search Another Location option
         menu.addItem(
             NSMenuItem(
-                title: "Search Another Location", action: #selector(searchAnotherLocation),
+                title: NSLocalizedString("search_another_location", comment: ""),
+                action: #selector(searchAnotherLocation),
                 keyEquivalent: ""))
-        let alwaysOnTopItem = NSMenuItem(
-            title: "Always on Top", action: #selector(toggleAlwaysOnTop), keyEquivalent: "")
-        alwaysOnTopItem.state = isAlwaysOnTop ? .on : .off
-        menu.addItem(alwaysOnTopItem)
-        menu.addItem(NSMenuItem(title: "About", action: #selector(showAbout), keyEquivalent: ""))
+
+        // Language submenu with emoji flags
+        let languageMenuItem = NSMenuItem(
+            title: NSLocalizedString("change_language", comment: ""), action: nil, keyEquivalent: ""
+        )
+        let languageSubMenu = NSMenu()
+
+        let englishItem = NSMenuItem(
+            title: "English", action: #selector(setLanguage(_:)), keyEquivalent: "")
+        englishItem.tag = 0
+
+        let greekItem = NSMenuItem(
+            title: "Ελληνικά", action: #selector(setLanguage(_:)), keyEquivalent: "")
+        greekItem.tag = 1
+
+        let albanianItem = NSMenuItem(
+            title: "Shqip", action: #selector(setLanguage(_:)), keyEquivalent: "")
+        albanianItem.tag = 2
+
+        languageSubMenu.addItem(englishItem)
+        languageSubMenu.addItem(greekItem)
+        languageSubMenu.addItem(albanianItem)
+        languageMenuItem.submenu = languageSubMenu
+        menu.addItem(languageMenuItem)
+
+        // About and Quit options
         menu.addItem(NSMenuItem.separator())
-        menu.addItem(NSMenuItem(title: "Quit", action: #selector(quitApp), keyEquivalent: "q"))
+        menu.addItem(
+            NSMenuItem(
+                title: NSLocalizedString("about", comment: ""), action: #selector(showAbout),
+                keyEquivalent: ""))
+        menu.addItem(
+            NSMenuItem(
+                title: NSLocalizedString("quit", comment: ""), action: #selector(quitApp),
+                keyEquivalent: "q"))
+
         statusItem.menu = menu
         statusItem.button?.performClick(nil)
         statusItem.menu = nil
@@ -162,11 +199,17 @@ class AppDelegate: NSObject, NSApplicationDelegate {
     }
 
     private func loadImage(from url: URL, completion: @escaping (NSImage) -> Void) {
-        DispatchQueue.global().async {
-            if let data = try? Data(contentsOf: url), let image = NSImage(data: data) {
-                DispatchQueue.main.async { completion(image) }
+        let task = URLSession.shared.dataTask(with: url) { data, response, error in
+            if let data = data, let image = NSImage(data: data) {
+                DispatchQueue.main.async {
+                    completion(image)
+                }
+            } else if let error = error {
+                print("Failed to load image from \(url): \(error.localizedDescription)")
             }
         }
+        task.priority = URLSessionTask.highPriority  // Set a high priority if necessary
+        task.resume()
     }
 
     private func resizeImage(image: NSImage, toFit targetSize: CGSize) -> NSImage {
@@ -319,6 +362,30 @@ class AppDelegate: NSObject, NSApplicationDelegate {
         }
     }
 
+    @objc private func setLanguage(_ sender: NSMenuItem) {
+        switch sender.tag {
+        case 0:
+            currentLanguage = "en"
+        case 1:
+            currentLanguage = "el"
+        case 2:
+            currentLanguage = "sq"
+        default:
+            break
+        }
+        print("Current language set to: \(currentLanguage)")  // Print the current language
+        updateLanguage()
+    }
+
+    private func updateLanguage() {
+        print("Updating UI language to: \(currentLanguage)")  // Print the language during update
+        Bundle.setLanguage(currentLanguage)
+
+        // Reload the app's UI with the new language setting
+        popover.contentViewController = NSHostingController(
+            rootView: ContentView(weatherManager: weatherManager, state: contentViewState))
+    }
+
     @objc func quitApp() {
         NSApp.terminate(nil)
     }
@@ -337,3 +404,35 @@ class AppDelegate: NSObject, NSApplicationDelegate {
         }
     }
 }
+
+// MARK: - Bundle Extension for Language Switching
+
+extension Bundle {
+    private static var onLanguageDispatchOnce: () -> Void = {
+        object_setClass(Bundle.main, LanguageBundle.self)
+    }
+
+    static func setLanguage(_ language: String) {
+        onLanguageDispatchOnce()
+        UserDefaults.standard.set([language], forKey: "AppleLanguages")
+        UserDefaults.standard.synchronize()
+    }
+}
+
+private class LanguageBundle: Bundle, @unchecked Sendable {
+    override func localizedString(forKey key: String, value: String?, table tableName: String?)
+        -> String
+    {
+        let language = UserDefaults.standard.stringArray(forKey: "AppleLanguages")?.first ?? "en"
+
+        // Check if the language-specific bundle path is available
+        guard let bundlePath = Bundle.main.path(forResource: language, ofType: "lproj"),
+            let languageBundle = Bundle(path: bundlePath)
+        else {
+            print("Fallback to main bundle for language: \(language)")  // Debugging output
+            return super.localizedString(forKey: key, value: value, table: tableName)
+        }
+
+        return languageBundle.localizedString(forKey: key, value: value, table: tableName)
+    }
+}