coderabbit

Signed-off-by: Peter M <petermm@gmail.com>

Author: petermm

.github/workflows/build-libraries.yaml

@@ -48,7 +48,7 @@ jobs:
     - name: "Install specific MbedTLS version"
       if: matrix.mbedtls == 'mbedtls@4'
       run: |
-        git clone --depth 1 --branch v4.0.0 https://github.com/Mbed-TLS/mbedtls
+        git clone --depth 1 --branch mbedtls-4.0.0 --recurse-submodules https://github.com/Mbed-TLS/mbedtls
         cd mbedtls
         mkdir build
         cd build

src/platforms/emscripten/src/lib/emscripten_sys.h

@@ -33,15 +33,14 @@
 #include <emscripten/fetch.h>
 #include <emscripten/promise.h>
 
+#include <mbedtls/version.h>
+#include "sys_mbedtls.h"
+
 #if MBEDTLS_VERSION_NUMBER < 0x04000000
 #include <mbedtls/ctr_drbg.h>
 #include <mbedtls/entropy.h>
 #endif
 
-#include <mbedtls/version.h>
-
-#include "sys_mbedtls.h"
-
 struct PromiseResource
 {
     em_promise_t promise;

src/platforms/esp32/components/avm_sys/include/esp32_sys.h

@@ -81,8 +81,6 @@ struct ESP32PlatformData
 #endif
 #if MBEDTLS_VERSION_NUMBER < 0x04000000
     mbedtls_entropy_context entropy_ctx;
-#else
-    char entropy_ctx;
 #endif
     bool entropy_is_initialized;
 
@@ -91,8 +89,6 @@ struct ESP32PlatformData
 #endif
 #if MBEDTLS_VERSION_NUMBER < 0x04000000
     mbedtls_ctr_drbg_context random_ctx;
-#else
-    char random_ctx;
 #endif
     bool random_is_initialized;
 

src/platforms/rp2/src/lib/rp2_sys.h

@@ -97,9 +97,6 @@ struct RP2PlatformData
 #endif
     mbedtls_ctr_drbg_context random_ctx;
     bool random_is_initialized;
-#else
-    char entropy_ctx;
-    char random_ctx;
 #endif
 };