Add erlang node/1 BIF

Implement erlang:node/1 for pid, port, and reference terms.\nAdd coverage for local, external, and badarg cases in test_node.

Signed-off-by: Peter M <petermm@gmail.com>

Author: petermm

libs/estdlib/src/erlang.erl

@@ -158,6 +158,7 @@
     length/1,
     list_to_float/1,
     node/0,
+    node/1,
     round/1,
     self/0,
     setelement/3,
@@ -1894,6 +1895,17 @@ list_to_float(_String) ->
 node() ->
     erlang:nif_error(undefined).
 
+%%-----------------------------------------------------------------------------
+%% @param   Item  a pid, port, or reference
+%% @returns the node name associated with `Item'
+%% @doc     Return the node name for a pid, port, or reference.
+%% Raises `badarg' if `Item' is not a pid, port, or reference.
+%% @end
+%%-----------------------------------------------------------------------------
+-spec node(Item :: pid() | port() | reference()) -> node().
+node(_Item) ->
+    erlang:nif_error(undefined).
+
 %%-----------------------------------------------------------------------------
 %% @param   Number  the number to round
 %% @returns `Number' rounded to the nearest integer

src/libAtomVM/bif.c

@@ -104,6 +104,15 @@ term bif_erlang_node_0(Context *ctx)
     return ctx->global->node_name;
 }
 
+term bif_erlang_node_1(Context *ctx, uint32_t fail_label, term arg1)
+{
+    if (term_is_pid(arg1) || term_is_port(arg1) || term_is_reference(arg1)) {
+        return term_is_external(arg1) ? term_get_external_node(arg1) : ctx->global->node_name;
+    }
+
+    RAISE_ERROR_BIF(fail_label, BADARG_ATOM);
+}
+
 term bif_erlang_byte_size_1(Context *ctx, uint32_t fail_label, int live, term arg1)
 {
     UNUSED(live);

src/libAtomVM/bif.h

@@ -43,6 +43,7 @@ const struct ExportedFunction *bif_registry_get_handler(const char *mfa);
 
 term bif_erlang_self_0(Context *ctx);
 term bif_erlang_node_0(Context *ctx);
+term bif_erlang_node_1(Context *ctx, uint32_t fail_label, term arg1);
 term bif_erlang_byte_size_1(Context *ctx, uint32_t fail_label, int live, term arg1);
 term bif_erlang_bit_size_1(Context *ctx, uint32_t fail_label, int live, term arg1);
 term bif_erlang_binary_part_3(Context *ctx, uint32_t fail_label, int live, term arg1, term arg2, term arg3);

src/libAtomVM/bifs.gperf

@@ -42,6 +42,7 @@ struct BifNameAndPtr
 %%
 erlang:self/0, {.bif.base.type = BIFFunctionType, .bif.bif0_ptr = bif_erlang_self_0}
 erlang:node/0, {.bif.base.type = BIFFunctionType, .bif.bif0_ptr = bif_erlang_node_0}
+erlang:node/1, {.bif.base.type = BIFFunctionType, .bif.bif1_ptr = bif_erlang_node_1}
 erlang:length/1, {.gcbif.base.type = GCBIFFunctionType, .gcbif.gcbif1_ptr = bif_erlang_length_1}
 erlang:byte_size/1, {.gcbif.base.type = GCBIFFunctionType, .gcbif.gcbif1_ptr = bif_erlang_byte_size_1}
 erlang:bit_size/1, {.gcbif.base.type = GCBIFFunctionType, .gcbif.gcbif1_ptr = bif_erlang_bit_size_1}

tests/erlang_tests/test_node.erl

@@ -34,6 +34,17 @@ start() ->
 
 test_node_no_distribution() ->
     nonode@nohost = node(),
+    nonode@nohost = node(self()),
+    nonode@nohost = node(make_ref()),
+    LocalPort = open_port({spawn, "echo"}, []),
+    nonode@nohost = node(LocalPort),
+    port_close(LocalPort),
+    nonode@nohost = node(external_port(nonode@nohost, 0)),
+    ok = assert_badarg(fun() -> node(test) end),
+    ok = assert_badarg(fun() -> node({test, nonode@nohost}) end),
+    test@test_node = node(external_pid()),
+    test@test_node = node(external_ref()),
+    test@test_node = node(external_port(test@test_node, 42)),
     ok.
 
 test_node_distribution() ->
@@ -49,6 +60,9 @@ test_node_distribution() ->
     true = erlang:setnode(test@test_node, 42),
     42 = get_creation(),
     test@test_node = node(),
+    test@test_node = node(self()),
+    test@test_node = node(make_ref()),
+    test@test_node = node(external_port(test@test_node, 42)),
     NetKernelPid ! quit,
     ok =
         receive
@@ -83,6 +97,33 @@ get_creation() ->
             erts_internal:get_creation()
     end.
 
+external_pid() ->
+    binary_to_term(
+        <<131, 88, 119, 14, "test@test_node", 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 42>>
+    ).
+
+external_ref() ->
+    binary_to_term(
+        <<131, 90, 0, 1, 119, 14, "test@test_node", 42:32, 1:32>>
+    ).
+
+external_port(Node, Creation) ->
+    term_from_node(Node, fun(NodeBin) ->
+        binary_to_term(<<131, 120, NodeBin/binary, 43:64, Creation:32>>)
+    end).
+
+term_from_node(Node, Fun) ->
+    NodeBin = atom_to_binary(Node, utf8),
+    Fun(<<119, (byte_size(NodeBin)), NodeBin/binary>>).
+
+assert_badarg(Fun) ->
+    try
+        Fun(),
+        unexpected_success
+    catch
+        error:badarg -> ok
+    end.
+
 sleep(Ms) ->
     receive
     after Ms -> ok