Skip to content

Commit 83b2bfa

Browse files
committed
edit docs
1 parent f233627 commit 83b2bfa

File tree

2 files changed

+19
-15
lines changed

2 files changed

+19
-15
lines changed

glutil.js

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1070,12 +1070,6 @@ BufferedSubMesh.prototype.draw=function(program){
10701070
context.drawElements(primitive,
10711071
this.facesLength,
10721072
this.type, 0);
1073-
// Disable attributes to avoid them leaking in future
1074-
// drawElements calls (in case a future vertex buffer object
1075-
// that doesn't use the attribute needs to be drawn)
1076-
for(var i=0;i<boundAttributes.length;i++){
1077-
//context.disableVertexAttribArray(boundAttributes[i]);
1078-
}
10791073
}
10801074
/**
10811075
* @private
@@ -1961,25 +1955,35 @@ ShapeGroup.prototype.getMatrix=function(){
19611955
}
19621956
/**
19631957
* Not documented yet.
1964-
* @param {Transform} transform
1958+
* @param {glutil.Transform} transform
19651959
*/
19661960
ShapeGroup.prototype.setTransform=function(transform){
19671961
this.transform=transform.copy();
19681962
return this;
19691963
}
19701964
/**
1971-
* Not documented yet.
1972-
* @param {*} x
1973-
* @param {*} y
1974-
* @param {*} z
1965+
* Sets the relative position of the shapes in this group
1966+
* from their original position.
1967+
* See {@link glutil.Transform#setPosition}
1968+
* This method will modify this shape group's transform
1969+
* rather than the transform for each shape in the group.
1970+
* @param {number|Array<number>} x X coordinate
1971+
* or a 3-element position array, as specified in {@link glutil.Transform#setScale}.
1972+
* @param {number} y Y-coordinate.
1973+
* @param {number} z Z-coordinate.
1974+
* @return {glutil.Scene3D} This object.
19751975
*/
19761976
ShapeGroup.prototype.setPosition=function(x,y,z){
19771977
this.transform.setPosition(x,y,z)
19781978
return this;
19791979
}
19801980
/**
1981-
* Not documented yet.
1982-
* @param {*} quat
1981+
* Sets this shape group's orientation in the form of a [quaternion]{@tutorial glmath}.
1982+
* See {@link glutil.Transform#setQuaternion}.
1983+
* This method will modify this shape group's transform
1984+
* rather than the transform for each shape in the group.
1985+
* @param {Array<number>} quat A four-element array describing the rotation.
1986+
* @return {glutil.Shape} This object.
19831987
*/
19841988
ShapeGroup.prototype.setQuaternion=function(quat){
19851989
this.transform.setQuaternion(quat);

glutil_min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)