Fix #44: DNS zones check: object of type 'bool' has no len()

Also:
- Switch to separate logging module pplogger
- Add release script

Author: peterpakos

checkipaconsistency/__init__.py

@@ -22,4 +22,4 @@
 along with this program.  If not, see <http://www.gnu.org/licenses/>.
 """
 
-VERSION = '2.7.1'
+VERSION = '2.7.2'

checkipaconsistency/freeipaserver.py

@@ -300,7 +300,10 @@ def _count_dns_zones(self):
             '(|(objectClass=idnszone)(objectClass=idnsforwardzone))',
             scope=ldap.SCOPE_ONELEVEL
         )
-        r = len(results)
+        if not results and type(results) is not list:
+            r = 0
+        else:
+            r = len(results)
         self._log.debug(r)
         return r
 

checkipaconsistency/logger.py

@@ -34,8 +34,8 @@
 except ImportError:
     import ConfigParser as configparser
 
+from pplogger import get_logger
 from . import VERSION
-from .logger import get_logger
 from .freeipaserver import FreeIPAServer
 
 

checkipaconsistency/main.py

@@ -0,0 +1,19 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+if [[ "$@" == "test" ]]; then
+  test="test"
+else
+  test=""
+fi
+
+for f in *.md; do
+  pandoc -s -f gfm -t rst "$f" > "${f%.md}.rst"
+done
+
+python setup.py "${test}release" || true
+
+for f in *.md; do
+  rm -f "${f%.md}.rst"
+done

release

@@ -1,3 +1,4 @@
+pplogger>=2.0.0
 dnspython>=1.15.0
 prettytable>=0.7.2
 pyldap>=2.4.45

requirements.txt

@@ -23,6 +23,7 @@ classifiers =
 include_package_data = True
 packages = checkipaconsistency
 install_requires =
+    pplogger>=2.0.0
     pyldap>=2.4.45
     prettytable>=0.7.2
     dnspython>=1.15.0