fix fatal when trying to access non-existing method on P2P_Side_User

Author: petitphp

facetwp-p2p.php

@@ -70,10 +70,15 @@ public function p2p_sources( $sources = array() ) {
 		$options    = array();
 		$connexions = P2P_Connection_Type_Factory::get_all_instances();
 		foreach ( $connexions as $connexion ) {
-			$from_ptype = get_post_type_object( $connexion->side['from']->first_post_type() );
-			$to_ptype = get_post_type_object( $connexion->side['to']->first_post_type() );
-			$options[ sprintf( 'p2p/%s/%s', $connexion->name, $from_ptype->name ) ] = sprintf( "[%s → %s] %s", $from_ptype->labels->singular_name, $to_ptype->labels->singular_name, $from_ptype->labels->singular_name );
-			$options[ sprintf( 'p2p/%s/%s', $connexion->name, $to_ptype->name ) ] = sprintf( "[%s → %s] %s", $from_ptype->labels->singular_name, $to_ptype->labels->singular_name, $to_ptype->labels->singular_name );
+			$from_ptype = $this->parse_side( $connexion->side['from'] );
+			$to_ptype = $this->parse_side( $connexion->side['to'] );
+			$options[ sprintf( 'p2p/%s/%s', $connexion->name, $from_ptype->name ) ] = sprintf( "[%s → %s] %s", $from_ptype->singular_name, $to_ptype->singular_name, $from_ptype->singular_name );
+			$options[ sprintf( 'p2p/%s/%s', $connexion->name, $to_ptype->name ) ] = sprintf( "[%s → %s] %s", $from_ptype->singular_name, $to_ptype->singular_name, $to_ptype->singular_name );
+		}
+
+		// don't add source if no options available
+		if ( empty( $options ) ) {
+			return $sources;
 		}
 
 		$sources['p2p'] = array(
@@ -100,14 +105,19 @@ public function p2pmetas_sources( $sources = array() ) {
 				continue;
 			}
 
-			$from_ptype = get_post_type_object( $connexion->side['from']->first_post_type() );
-			$to_ptype   = get_post_type_object( $connexion->side['to']->first_post_type() );
+			$from_ptype = $this->parse_side( $connexion->side['from'] );
+			$to_ptype   = $this->parse_side( $connexion->side['to'] );
 			foreach ( $connexion->fields as $field_name => $field_options ) {
 				$field_title = ! empty( $field_options['title'] ) ? $field_options['title'] : $field_name;
-				$options[ sprintf( 'p2pmeta/%s/%s', $connexion->name, $field_name ) ] = sprintf( "[%s → %s] %s", $from_ptype->labels->singular_name, $to_ptype->labels->singular_name, $field_title );
+				$options[ sprintf( 'p2pmeta/%s/%s', $connexion->name, $field_name ) ] = sprintf( "[%s → %s] %s", $from_ptype->singular_name, $to_ptype->singular_name, $field_title );
 			}
 		}
 
+		// don't add source if no options available
+		if ( empty( $options ) ) {
+			return $sources;
+		}
+
 		$sources['p2p_meta'] = array(
 			'label'   => __( 'Posts 2 Posts Meta', 'facetwp-p2p' ),
 			'choices' => $options,
@@ -199,7 +209,7 @@ public function p2pmetas_indexer( $bypass, $defaults ) {
 			return true;
 		}
 
-		$p2p_column = $connexion_type->side['from']->first_post_type() === $post_ptype ? 'p2p_from' : 'p2p_to';
+		$p2p_column = $this->get_post_type( $connexion_type->side['from'] ) === $post_ptype ? 'p2p_from' : 'p2p_to';
 
 		$p2p_ids = $wpdb->get_col(
 			$wpdb->prepare(
@@ -362,23 +372,60 @@ protected function get_facet_source_for_p2p_connection( $p2p_id, $direction = fa
 			return sprintf(
 				'p2p/%s/%s',
 				$connexion->p2p_type,
-				$connexion_type->side[ $direction ]->first_post_type()
+				$this->get_post_type( $connexion_type->side[ $direction ] )
 			);
 		}
 
 		return array(
 			'from' => sprintf(
 				'p2p/%s/%s',
 				$connexion->p2p_type,
-				$connexion_type->side['from']->first_post_type()
+				$this->get_post_type( $connexion_type->side['from'] )
 			),
 			'to'   => sprintf(
 				'p2p/%s/%s',
 				$connexion->p2p_type,
-				$connexion_type->side['to']->first_post_type()
+				$this->get_post_type( $connexion_type->side['to'] )
 			)
 		);
 	}
+
+	/**
+	 * Get post type for a P2P_Side.
+	 *
+	 * Handle special case for P2P_Side_User.
+	 *
+	 * @param P2P_Side $side
+	 *
+	 * @return string
+	 */
+	protected function get_post_type( $side ) {
+		return ( is_a( $side, 'P2P_Side_User' ) ) ? 'user' : $side->first_post_type();
+	}
+
+	/**
+	 * Prepare data for a P2P_Side.
+	 *
+	 * @param P2P_Side $side
+	 *
+	 * @return object
+	 */
+	protected function parse_side( $side ) {
+		$data = [];
+
+		$type = $this->get_post_type( $side );
+
+		if ( 'user' === $type ) {
+			$data['name'] = 'user';
+			$data['singular_name'] = 'User';
+		} else {
+			$ptype = get_post_type_object( $type );
+			$data['name'] = $ptype->name;
+			$data['singular_name'] = $ptype->labels->singular_name;
+		}
+
+		return (object) $data;
+	}
 }
 
 /**
@@ -425,4 +472,4 @@ function FWP_P2P_init() {
 	FWP_P2P();
 }
 
-add_action( 'plugins_loaded', 'FWP_P2P_init' );
+add_action( 'plugins_loaded', 'FWP_P2P_init' );