Skip to content

Commit 0d8485b

Browse files
committed
Merge branch 'PHP-8.4'
2 parents 134b11f + 52e0d79 commit 0d8485b

File tree

3 files changed

+16
-8
lines changed

3 files changed

+16
-8
lines changed

cmake/cmake/Configuration.cmake

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,11 @@ mark_as_advanced(PHP_DMALLOC)
133133
option(PHP_DTRACE "Enable DTrace support" OFF)
134134
mark_as_advanced(PHP_DTRACE)
135135

136-
set(PHP_FD_SETSIZE "" CACHE STRING "Size of descriptor sets")
136+
if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
137+
set(PHP_FD_SETSIZE "256" CACHE STRING "Size of descriptor sets")
138+
else()
139+
set(PHP_FD_SETSIZE "" CACHE STRING "Size of descriptor sets")
140+
endif()
137141
mark_as_advanced(PHP_FD_SETSIZE)
138142

139143
option(PHP_VALGRIND "Enable the Valgrind support" OFF)

cmake/cmake/modules/PHP/Stubs/PHPStubsGenerator.cmake.in

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
Script for processing PHP stub sources.
33
#]=============================================================================]
44

5+
if(NOT CMAKE_SCRIPT_MODE_FILE)
6+
message(FATAL_ERROR "This is a command-line script.")
7+
endif()
8+
59
set(sources "@PHP_SOURCES@")
610

711
# Ensure sources include only *.stub.php files.

cmake/cmake/scripts/GenerateCredits.cmake

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/env -S cmake -P
22
#
3-
# Command-line script to regenerate the ext/standard/credits_*.h headers from
4-
# CREDITS files.
3+
# Command-line script to regenerate the `ext/standard/credits_*.h` headers from
4+
# the `CREDITS` files.
55
#
66
# Run with: `cmake -P cmake/scripts/GenerateCredits.cmake`
77

@@ -33,9 +33,9 @@ set(template [[
3333
file(GLOB credits ${PHP_SOURCE_DIR}/*/*/CREDITS)
3434

3535
foreach(credit ${credits})
36-
cmake_path(GET credit PARENT_PATH parent)
37-
cmake_path(GET parent PARENT_PATH parent)
38-
cmake_path(GET parent FILENAME dir)
36+
cmake_path(GET credit PARENT_PATH dir)
37+
cmake_path(GET dir PARENT_PATH dir)
38+
cmake_path(GET dir FILENAME dir)
3939

4040
list(APPEND dirs ${dir})
4141
file(STRINGS ${credit} lines ENCODING UTF-8)
@@ -48,8 +48,8 @@ list(REMOVE_DUPLICATES dirs)
4848

4949
foreach(dir ${dirs})
5050
list(SORT ${dir}_credits CASE INSENSITIVE)
51-
list(JOIN ${dir}_credits ";\n" credits)
52-
set(content "${template}${credits};\n")
51+
list(JOIN ${dir}_credits ";\n" content)
52+
set(content "${template}${content};\n")
5353

5454
if(EXISTS ${PHP_SOURCE_DIR}/ext/standard/credits_${dir}.h)
5555
file(READ ${PHP_SOURCE_DIR}/ext/standard/credits_${dir}.h current)

0 commit comments

Comments
 (0)