Remove gdbm integration (PHP-8.3)

This follows commit 13986fa because
GDBM is licensed under GNU GPL 3, which makes it incompatible in
real-case server-based environments. Instead of providing configuration
for GDBM, it is easier to simply remove it and provide simpler
configuration to the user building/installing software.

Author: petk

cmake/cmake/modules/FindDbm.cmake

@@ -6,7 +6,8 @@ Find the dbm library.
 Depending on the system, the dbm library can be part of other libraries as an
 interface.
 
-* GNU dbm has compatibility interface via gdbm_compatibility
+* GNU dbm library (GDBM) has compatibility interface via gdbm_compatibility but
+  it is licensed as GPL 3, which is incompatible with PHP.
 * TODO: Built into default libraries (C): Solaris still has some macros
   definitions mapping to internal dbm functions available in the db.h header.
   When defining `DB_DBM_HSEARCH` dbm handler is available as built into C
@@ -24,8 +25,6 @@ Module defines the following `IMPORTED` target(s):
 * `Dbm_IS_BUILT_IN` - Whether dbm is a part of the C library.
 * `Dbm_INCLUDE_DIRS` - Include directories needed to use this package.
 * `Dbm_LIBRARIES` - Libraries needed to link to the package library.
-* `Dbm_IMPLEMENTATION` - String of the library name that implements the dbm
-  library.
 
 ## Cache variables
 
@@ -77,7 +76,6 @@ else()
   find_path(
     Dbm_INCLUDE_DIR
     NAMES dbm.h
-    PATH_SUFFIXES gdbm
     DOC "Directory containing dbm library headers"
   )
 
@@ -87,9 +85,7 @@ else()
 
   find_library(
     Dbm_LIBRARY
-    NAMES
-      gdbm_compat
-      dbm
+    NAMES dbm
     DOC "The path to the dbm library"
   )
 
@@ -109,12 +105,6 @@ else()
   mark_as_advanced(Dbm_INCLUDE_DIR Dbm_LIBRARY)
 endif()
 
-if(Dbm_LIBRARY MATCHES "gdbm_compat")
-  set(Dbm_IMPLEMENTATION "GDBM")
-elseif(Dbm_LIBRARY)
-  set(Dbm_IMPLEMENTATION "DBM")
-endif()
-
 find_package_handle_standard_args(
   Dbm
   REQUIRED_VARS

cmake/cmake/modules/FindGDBM.cmake

@@ -6,8 +6,9 @@ Find the ndbm library.
 Depending on the system, the nbdm ("new" dbm) can be part of other libraries as
 an interface.
 
-* GNU dbm library (GDBM) has a compatibility interface that provides ndbm.h
-  header and gdbm_compat library.
+* GNU dbm library (GDBM) has compatibility interface via gdbm_compatibility that
+  provides ndbm.h header but it is licensed as GPL 3, which is incompatible with
+  PHP.
 * Built into default libraries (C): BSD-based systems, macOS, Solaris.
 
 Module defines the following `IMPORTED` target(s):
@@ -83,7 +84,6 @@ else()
     Ndbm_LIBRARY
     NAMES
       ndbm
-      gdbm_compat
       db1
     DOC "The path to the ndbm library"
   )

cmake/cmake/modules/FindNdbm.cmake

@@ -66,13 +66,6 @@ Enable the legacy (original) Berkeley DB style (Database Manager) handler.
 
 Enable the bundled flat-file DBA handler.
 
-## PHP_EXT_DBA_GDBM
-
-* Default: `OFF`
-* Values: `ON|OFF`
-
-Enable the GNU dbm (GDBM) handler.
-
 ## PHP_EXT_DBA_INIFILE
 
 * Default: `ON`
@@ -218,20 +211,6 @@ add_feature_info(
   "bundled flat-file handler"
 )
 
-cmake_dependent_option(
-  PHP_EXT_DBA_GDBM
-  "DBA: Enable the GNU dbm (GDBM) handler"
-  OFF
-  [[PHP_EXT_DBA AND NOT PHP_EXT_DBA_QDBM]]
-  OFF
-)
-mark_as_advanced(PHP_EXT_DBA_GDBM)
-add_feature_info(
-  "ext/dba GDBM"
-  PHP_EXT_DBA_GDBM
-  "GNU dbm handler"
-)
-
 cmake_dependent_option(
   PHP_EXT_DBA_INIFILE
   "DBA: Enable the bundled INI-file handler"
@@ -277,21 +256,15 @@ cmake_dependent_option(
   PHP_EXT_DBA_QDBM
   "DBA: Enable the Quick Database Manager (QDBM) handler"
   OFF
-  [[PHP_EXT_DBA AND NOT PHP_EXT_DBA_DBM AND NOT PHP_EXT_DBA_GDBM]]
+  [[PHP_EXT_DBA AND NOT PHP_EXT_DBA_DBM]]
   OFF
 )
 add_feature_info(
   "ext/dba QDBM"
   PHP_EXT_DBA_QDBM
   "Quick Database Manager handler"
 )
-if(PHP_EXT_DBA_QDBM AND PHP_EXT_DBA_GDBM)
-  message(
-    FATAL_ERROR
-    "You cannot combine 'PHP_EXT_DBA_GDBM' with 'PHP_EXT_DBA_QDBM'. Please "
-    "select either GDBM or QDBM."
-  )
-elseif(PHP_EXT_DBA_QDBM AND PHP_EXT_DBA_DBM)
+if(PHP_EXT_DBA_QDBM AND PHP_EXT_DBA_DBM)
   message(
     FATAL_ERROR
     "You cannot combine 'PHP_EXT_DBA_DBM' with 'PHP_EXT_DBA_QDBM'. Please "
@@ -452,24 +425,13 @@ if(PHP_EXT_DBA_DBM)
       PURPOSE "Necessary to enable the DBM handler in the dba extension."
   )
 
-  if(Dbm_LIBRARY MATCHES "gdbm")
-    message(
-      WARNING
-      "The GNU dbm (GDBM) library is licensed under the GNU GPL 3, which is "
-      "not compatible with the PHP license. PHP then shouldn't be distributed. "
-      "The PHP_EXT_DBA_DBM is a legacy artifact for testing purposes. The "
-      "recommendation for using and distributing the PHP 'dba' extension is to "
-      "disable the PHP_EXT_DBA_DBM."
-    )
-  endif()
-
   target_link_libraries(php_ext_dba PRIVATE Dbm::Dbm)
 
   target_sources(php_ext_dba PRIVATE dba_dbm.c)
 
   set(DBM_INCLUDE_FILE "<dbm.h>")
   set(DBA_DBM TRUE)
-  set(DBM_VERSION "${Dbm_IMPLEMENTATION}")
+  set(DBM_VERSION "DBM")
 endif()
 
 ################################################################################
@@ -486,34 +448,6 @@ if(PHP_EXT_DBA_FLATFILE)
   set(DBA_FLATFILE TRUE)
 endif()
 
-################################################################################
-# GDBM.
-################################################################################
-if(PHP_EXT_DBA_GDBM)
-  message(
-    WARNING
-    "The GNU dbm (GDBM) library is licensed under the GNU GPL 3, which is not "
-    "compatible with the PHP license. PHP then shouldn't be distributed. The "
-    "recommendation for using and distributing the PHP 'dba' extension is to "
-    "disable PHP_EXT_DBA_GDBM."
-  )
-
-  find_package(GDBM)
-  set_package_properties(
-    GDBM
-    PROPERTIES
-      TYPE REQUIRED
-      PURPOSE "Necessary to enable the GDBM handler in the dba extension."
-  )
-
-  target_link_libraries(php_ext_dba PRIVATE GDBM::GDBM)
-
-  target_sources(php_ext_dba PRIVATE dba_gdbm.c)
-
-  set(GDBM_INCLUDE_FILE "<gdbm.h>")
-  set(DBA_GDBM TRUE)
-endif()
-
 ################################################################################
 # INI-file.
 ################################################################################
@@ -560,17 +494,6 @@ if(PHP_EXT_DBA_NDBM)
       PURPOSE "Necessary to enable the ndbm handler in the dba extension."
   )
 
-  if(Ndbm_LIBRARY MATCHES "gdbm")
-    message(
-      WARNING
-      "The GNU dbm (GDBM) library is licensed under the GNU GPL 3, which is "
-      "not compatible with the PHP license. PHP then shouldn't be distributed. "
-      "The PHP_EXT_DBA_NDBM is a legacy artifact for testing purposes. The "
-      "recommendation for using and distributing the PHP 'dba' extension is to "
-      "disable the PHP_EXT_DBA_NDBM."
-    )
-  endif()
-
   target_link_libraries(php_ext_dba PRIVATE Ndbm::Ndbm)
 
   target_sources(php_ext_dba PRIVATE dba_ndbm.c)
@@ -582,7 +505,7 @@ endif()
 ################################################################################
 # QDBM.
 ################################################################################
-if(PHP_EXT_DBA_QDBM AND NOT PHP_EXT_DBA_DBM AND NOT PHP_EXT_DBA_GDBM)
+if(PHP_EXT_DBA_QDBM AND NOT PHP_EXT_DBA_DBM)
   find_package(QDBM)
   set_package_properties(
     QDBM

cmake/ext/dba/CMakeLists.txt

@@ -44,9 +44,6 @@
 /* Define to 1 if the dba extension uses the bundled flatfile handler. */
 #cmakedefine DBA_FLATFILE 1
 
-/* Define to 1 if the dba extension uses the GDBM handler. */
-#cmakedefine DBA_GDBM 1
-
 /* Define to 1 if the dba extension uses the bundled inifile handler. */
 #cmakedefine DBA_INIFILE 1
 
@@ -68,9 +65,6 @@
 /* The DBM handler version information. */
 #cmakedefine DBM_VERSION "@DBM_VERSION@"
 
-/* The GDBM handler header file. */
-#cmakedefine GDBM_INCLUDE_FILE @GDBM_INCLUDE_FILE@
-
 /* Define to 1 if the PHP extension 'dba' is available. */
 #cmakedefine HAVE_DBA 1